Make "Accepted" definitions consistent for Core EIPs #1858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of EIP-1 had two conflicting definitions of what "Accepted" meant for Core EIPs. This harmonizes them.
timbeiko
changed the title
Arachnid
requested changes
Mar 25, 2019
timbeiko
commented
Mar 26, 2019
timbeiko
commented
Mar 26, 2019
|
@Arachnid great, thanks! What is the process for merging it in? Do you have write access? |
This was referenced Mar 29, 2019
nicksavers
suggested changes
Apr 1, 2019
|
@nicksavers thanks for the feedback. I think your point makes sense and I’ll close the first PR. |
Arachnid
pushed a commit
that referenced
this pull request
Apr 1, 2019
* Updated README to be consistent with EIP-1 Update README to be consistent with EIP and this PR: #1858 * Updated index.html Updated index.html to use the same definitions as the readme.
ilanolkies
pushed a commit
to ilanolkies/EIPs
that referenced
this pull request
Nov 12, 2019
) * Updated README to be consistent with EIP-1 Update README to be consistent with EIP and this PR: ethereum#1858 * Updated index.html Updated index.html to use the same definitions as the readme.
enjin-io
pushed a commit
to enjin-io/EIPs-1
that referenced
this pull request
Nov 13, 2023
* Updated README to be consistent with EIP-1 Update README to be consistent with EIP and this PR: ethereum/EIPs#1858 * Updated index.html Updated index.html to use the same definitions as the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-1 has two conflicting definitions of what "Accepted" meant for Core EIPs. This harmonizes them.