EIP-3534: Restricted Chain Context Type Transactions (Draft) #3534

whilei · 2021-04-26T20:22:55Z

This is submitting a Draft status Standards > Core proposal for consideration.

Simple Summary

Add a transaction type which contains a Chain Context value restricting a transaction's validity
to a chain meeting certain contextual requirements.

Signed-off-by: ia <isaac.ardis@gmail.com>

EIPS/eip-restricted_chain_context_txs.md

MicahZoltu · 2021-04-28T08:20:15Z

EIPS/eip-restricted_chain_context_txs.md

+
+##### Encoding
+
+Encoding should follow the same rules as the optional `accessList` value.


the access list is a nested structure, while this is just a simple array. This needs to be more explicitly specified. Consider just RLP encoding or SSZ encoding the list for compatibility with existing tools.

MicahZoltu · 2021-04-28T08:21:56Z

EIPS/eip-restricted_chain_context_txs.md

+
+##### Encoding
+
+Encoding should follow the same rules as other transaction integer values, eg. `nonce`, `gasPrice`, `gasLimit`, etc.


This doesn't specify where the timestamp should go. Also, be explicit about encoding mechanism rather than referring to other fields.

MicahZoltu · 2021-04-28T08:22:25Z

EIPS/eip-restricted_chain_context_txs.md

+- `ANNOTATION_PREFIX` `7` combines `segmentId` and `eligibleMinerList` and `expiry`. 
+
+
+Annotation values are provided in an array.


How is the array encoded into bytes?

How is the array affixed to the prefix?

How is array item order determined?

EIPS/eip-restricted_chain_context_txs.md

ethereum#3534 (review) Co-authored-by: Micah Zoltu <micah@zoltu.net>

Co-authored-by: Micah Zoltu <micah@zoltu.net>

whilei · 2021-04-28T12:53:28Z

@MicahZoltu Thank you for the thoughtful and valuable feedback. I'll address the remaining review comments ASAP, and will notify you when I've pushed for a second pass.

Co-authored-by: Micah Zoltu <micah@zoltu.net>

EIPS/eip-restricted_chain_context_txs.md

Fixes https://github.com/ethereum/EIPs/pull/3534/files#r621768642

Signed-off-by: ia <isaac.ardis@gmail.com>

ethereum#3534 (comment) Signed-off-by: ia <isaac.ardis@gmail.com>

ethereum#3534 (comment) I've chosen to use 'ancestorId' instead of the review-proposed 'ancestorHash' because the value is a synthesis of block number and hash values intended to uniquely identifiy a block. Signed-off-by: ia <isaac.ardis@gmail.com>

ethereum#3534 (comment) Signed-off-by: ia <isaac.ardis@gmail.com>

Signed-off-by: ia <isaac.ardis@gmail.com>

whilei · 2021-04-29T16:55:13Z

Hey again @MicahZoltu. As promised, I've made and now pushed quite a few changes in response to your excellent initial feedback.

I've used 👍 on your review comments as a personal way for me to track what I've tackled, and I think I've got them all covered (for now 😂).

Please forgive the ugly history; I'm assuming a merge will be a squash, and there isn't much use in trying to make sense of history at this point in the EIP's young life.

Thanks again for your time and attention.

EIPS/eip-3534.md

…t one Signed-off-by: ia <isaac.ardis@gmail.com>

Signed-off-by: ia <isaac.ardis@gmail.com>

MicahZoltu

A few more minor things, but once those are addressed we should be able to merge this as a draft.

EIPS/eip-3534.md

MicahZoltu · 2021-05-01T05:49:51Z

EIPS/eip-3534.md

+- `ELIGIBLE_MINER_LIST` `[address...]`. A list of addresses.
+- `MAX_ELEMENTS` `3`. The maximum number of addresses that can be provided.
+
+The `ELIGIBLE_MINER_LIST` value is an array of valid [address hashes](https://github.com/ethereum/yellowpaper/blob/41c1837f7b1ddcd65f135763c8e965146cd0ab70/Paper.tex#L321) referencing an exclusive, unique set of allowed [`beneficiary`](https://github.com/ethereum/yellowpaper/blob/41c1837f7b1ddcd65f135763c8e965146cd0ab70/Paper.tex#L336) values.


Avoid external links, including the Ethereum Yellow paper. It can be assumed that readers of this will know what an Ethereum address is. Also, you shouldn't call it an address hash, because an address is already a hash/truncation of a public key and address hash would be a hash of the address which I'm pretty sure is not what you want. Same with beneficiary, it can be assumed that readers of this will know what a block beneficiary is, so just call it that (note the addition of the word block).

MicahZoltu · 2021-05-01T05:50:06Z

EIPS/eip-3534.md

+- `INELIGIBLE_MINER_LIST` `[address...]`. A list of addresses.
+- `MAX_ELEMENTS` `3`. The maximum number of addresses that can be provided.
+
+The `INELIGIBLE_MINER_LIST` value is an array of valid [address hashes](https://github.com/ethereum/yellowpaper/blob/41c1837f7b1ddcd65f135763c8e965146cd0ab70/Paper.tex#L321) referencing an unique set of disallowed [`beneficiary`](https://github.com/ethereum/yellowpaper/blob/41c1837f7b1ddcd65f135763c8e965146cd0ab70/Paper.tex#L336) values.


Same comment as above, no external links and these two aren't necessary.

MicahZoltu · 2021-05-01T05:51:24Z

EIPS/eip-3534.md

+- `ANNOTATION_PREFIX` `8`.
+- `EXPIRY` `integer`. A positive, unsigned scalar.
+
+The `EXPIRY` value is a scalar equal to the maximum valid [`timestamp`](https://github.com/ethereum/yellowpaper/blob/41c1837f7b1ddcd65f135763c8e965146cd0ab70/Paper.tex#L345) of a block header for a block including this transaction.


Same comment as above, no external links and this one is unnecessary.

EIPS/eip-3534.md

MicahZoltu · 2021-05-01T05:54:58Z

EIPS/eip-3534.md

+The goal of the `ancestorId` is to disambiguate one chain segment from another, and in doing so, enable a transaction to define with adequate precision which chain it needs to be on.
+When a transaction's `ancestorId` references a block, we want to be pretty sure that that reference won't get confused with a different block than the one the author of the transaction had in mind.
+
+Block hashes are effectively unique (at least ethereum/go-ethereum assumes so in their database schema), and are [cited as approximations for random numbers in the yellow paper](https://github.com/ethereum/yellowpaper/blob/41c1837f7b1ddcd65f135763c8e965146cd0ab70/Paper.tex#L1261).


No external links. Also, this particular citation doesn't seem to add value to this discussion so I recommend just removing it. We can assume the readers of this document understand the uniqueness and collision resistant properties of the keccak256 hashing algorithm and the block hash selection process.

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Signed-off-by: ia <isaac.ardis@gmail.com>

alita-moore · 2021-05-01T11:59:47Z

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

 - File with name EIPS/eip-3534.md is new and new files must be reviewed

Signed-off-by: ia <isaac.ardis@gmail.com>

Assume the reader understands how hashes work.

Signed-off-by: ia <isaac.ardis@gmail.com>

whilei · 2021-05-01T12:13:39Z

@MicahZoltu As always and again, thank you. I've just pushed changes addressing all of your review comments.

Signed-off-by: ia <isaac.ardis@gmail.com>

…m#3534) Defines a new transaction type with constraints on ancestor block hash, block author, and/or block timestamp.

whilei added 4 commits April 26, 2021 15:12

init Restricted Chain Context Type Txs draft

b7bf33d

Signed-off-by: ia <isaac.ardis@gmail.com>

include copyright disclaimer

a58f38d

Signed-off-by: ia <isaac.ardis@gmail.com>

fix frontmatter title

db0bcd1

Signed-off-by: ia <isaac.ardis@gmail.com>

minor wording tweaks

3bcf1eb

Signed-off-by: ia <isaac.ardis@gmail.com>

MicahZoltu suggested changes Apr 28, 2021

View reviewed changes

whilei and others added 4 commits April 28, 2021 07:50

set EIP number 3534

ec90081

ethereum#3534 (review) Co-authored-by: Micah Zoltu <micah@zoltu.net>

set author to github handle instead of email

493a0bd

Co-authored-by: Micah Zoltu <micah@zoltu.net>

fix frontmatter 'requires' field, trimming dependent EIP- prefixes

809419a

Co-authored-by: Micah Zoltu <micah@zoltu.net>

remove title, unnecessary (provided by frontmatter)

9bdfd7f

Co-authored-by: Micah Zoltu <micah@zoltu.net>

remove invalid 'Reference' section

d833408

Co-authored-by: Micah Zoltu <micah@zoltu.net>

whilei commented Apr 28, 2021

View reviewed changes

EIPS/eip-restricted_chain_context_txs.md Outdated Show resolved Hide resolved

whilei and others added 18 commits April 28, 2021 08:00

add discussions-to link (Magicians' discourse site)

fd44c8a

Fixes https://github.com/ethereum/EIPs/pull/3534/files#r621768642

move file to eip-numbered name

f430427

Signed-off-by: ia <isaac.ardis@gmail.com>

include RLP encoding specs for all subclasses

5a2cc25

Signed-off-by: ia <isaac.ardis@gmail.com>

use EIP2718 Tx Type 4

2723193

ethereum#3534 (comment) Signed-off-by: ia <isaac.ardis@gmail.com>

use sentence-deliminted newline pattern

7cd77f7

ethereum#3534 (comment) Signed-off-by: ia <isaac.ardis@gmail.com>

shorten simple summary

859f8d8

ethereum#3534 (comment) Signed-off-by: ia <isaac.ardis@gmail.com>

rename segmentId -> ancestorId

fe64b0f

ethereum#3534 (comment) I've chosen to use 'ancestorId' instead of the review-proposed 'ancestorHash' because the value is a synthesis of block number and hash values intended to uniquely identifiy a block. Signed-off-by: ia <isaac.ardis@gmail.com>

firm up subclasses list (not tentative)

d2a8e51

ethereum#3534 (comment) Signed-off-by: ia <isaac.ardis@gmail.com>

again revise Simple Summary to be more precise

340e876

ethereum#3534 (comment) Signed-off-by: ia <isaac.ardis@gmail.com>

insert proposed spec for ANCESTOR_ID

c1897ae

ethereum#3534 (comment) Signed-off-by: ia <isaac.ardis@gmail.com>

minor tweak to link text re: block timestamp field

989e4d9

Signed-off-by: ia <isaac.ardis@gmail.com>

move ancestorId discussion to Rationale section

3fe3d86

Signed-off-by: ia <isaac.ardis@gmail.com>

add link to yellow paper for block beneficiary reference

8ef95a8

add EXPIRY definition as integer

6e7ceb7

🔨

39ec7e9

Signed-off-by: ia <isaac.ardis@gmail.com>

move example to test cases, rationale re annotation prefix system

5295169

Signed-off-by: ia <isaac.ardis@gmail.com>

write about why 4 bytes seems safe enough to me

b1df47b

Signed-off-by: ia <isaac.ardis@gmail.com>

include probability diagram image

5c4f491

Signed-off-by: ia <isaac.ardis@gmail.com>

whilei added 2 commits April 29, 2021 10:56

add rationale sections, improve example, etc.

4a9eb26

Signed-off-by: ia <isaac.ardis@gmail.com>

add ineligible miner list context

ba36ce4

Signed-off-by: ia <isaac.ardis@gmail.com>

whilei commented Apr 29, 2021

View reviewed changes

EIPS/eip-3534.md Outdated Show resolved Hide resolved

whilei added 6 commits April 29, 2021 12:16

maybe fix probabily reasoning; all combinations are eligible, not jus…

265fd8d

…t one Signed-off-by: ia <isaac.ardis@gmail.com>

fix typo

376c660

Signed-off-by: ia <isaac.ardis@gmail.com>

typos and minor improvements

641096b

Signed-off-by: ia <isaac.ardis@gmail.com>

move ineligibleMinerList discussion to Security Concerns

441954b

Signed-off-by: ia <isaac.ardis@gmail.com>

fixups and minor improvements

afe8e38

Signed-off-by: ia <isaac.ardis@gmail.com>

add security concern section for eligibleMinerList

36aec3c

Signed-off-by: ia <isaac.ardis@gmail.com>

whilei changed the title ~~EIP-[TBD]: Restricted Chain Context Type Transactions (Draft)~~ EIP-3534: Restricted Chain Context Type Transactions (Draft) Apr 29, 2021

MicahZoltu suggested changes May 1, 2021

View reviewed changes

whilei and others added 6 commits May 1, 2021 06:49

s/homogenous/homogeneous

0318d4c

Co-authored-by: Micah Zoltu <micah@zoltu.net>

s/contraints/constraints

5c13de1

Co-authored-by: Micah Zoltu <micah@zoltu.net>

use relative path for adjacent EIP link

5376ffc

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Core track EIPs assume hard fork requirement

4aa5f7a

Co-authored-by: Micah Zoltu <micah@zoltu.net>

normalize header level

86434d7

Co-authored-by: Micah Zoltu <micah@zoltu.net>

s/timespan/time span

778ac9a

Signed-off-by: ia <isaac.ardis@gmail.com>

whilei added 4 commits May 1, 2021 07:03

remove external links, and spellchecks

68d4b26

Signed-off-by: ia <isaac.ardis@gmail.com>

(minor) improve wording in a few places

cdd4216

remove discussion of block hash characteristics

a9f98dc

Assume the reader understands how hashes work.

normal Securty Concerns subheadings

2775b4a

Signed-off-by: ia <isaac.ardis@gmail.com>

whilei added 3 commits May 1, 2021 07:15

remove unnecessary detail from Simple Summary

7d9b3ea

Signed-off-by: ia <isaac.ardis@gmail.com>

one more note about chainid:ancestorid difference

85f0a1d

Signed-off-by: ia <isaac.ardis@gmail.com>

s/an/a

b61b356

Signed-off-by: ia <isaac.ardis@gmail.com>

MicahZoltu merged commit 59c3f29 into ethereum:master May 1, 2021

PhABC pushed a commit to PhABC/EIPs that referenced this pull request Jan 25, 2022

EIP-3534: Restricted Chain Context Type Transactions (Draft) (ethereu…

29a9418

…m#3534) Defines a new transaction type with constraints on ancestor block hash, block author, and/or block timestamp.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP-3534: Restricted Chain Context Type Transactions (Draft) #3534

EIP-3534: Restricted Chain Context Type Transactions (Draft) #3534

whilei commented Apr 26, 2021

MicahZoltu Apr 28, 2021

MicahZoltu Apr 28, 2021

MicahZoltu Apr 28, 2021

whilei commented Apr 28, 2021 •

edited

Loading

whilei commented Apr 29, 2021 •

edited

Loading

MicahZoltu left a comment

MicahZoltu May 1, 2021

MicahZoltu May 1, 2021

MicahZoltu May 1, 2021

MicahZoltu May 1, 2021

alita-moore commented May 1, 2021

whilei commented May 1, 2021


		##### Encoding

		Encoding should follow the same rules as the optional `accessList` value.

		- `ANNOTATION_PREFIX` `7` combines `segmentId` and `eligibleMinerList` and `expiry`.


		Annotation values are provided in an array.

EIP-3534: Restricted Chain Context Type Transactions (Draft) #3534

EIP-3534: Restricted Chain Context Type Transactions (Draft) #3534

Conversation

whilei commented Apr 26, 2021

Simple Summary

MicahZoltu Apr 28, 2021

Choose a reason for hiding this comment

MicahZoltu Apr 28, 2021

Choose a reason for hiding this comment

MicahZoltu Apr 28, 2021

Choose a reason for hiding this comment

whilei commented Apr 28, 2021 • edited Loading

whilei commented Apr 29, 2021 • edited Loading

MicahZoltu left a comment

Choose a reason for hiding this comment

MicahZoltu May 1, 2021

Choose a reason for hiding this comment

MicahZoltu May 1, 2021

Choose a reason for hiding this comment

MicahZoltu May 1, 2021

Choose a reason for hiding this comment

MicahZoltu May 1, 2021

Choose a reason for hiding this comment

alita-moore commented May 1, 2021

whilei commented May 1, 2021

whilei commented Apr 28, 2021 •

edited

Loading

whilei commented Apr 29, 2021 •

edited

Loading