Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1 #3613

Merged
merged 8 commits into from
Jun 17, 2021
Merged

Update EIP-1 #3613

merged 8 commits into from
Jun 17, 2021

Conversation

poojaranjan
Copy link
Contributor

Following updates done to the EIP-1

  • Links - ACD, FEM

  • Adding EIP editor - Matt Garnett

- Recommendation to open a discussion thread at FEM (only)

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

- Added EIP editor - Matt Garnett

- recommended to open a discussion thread at FEM (only recommended place)
@poojaranjan poojaranjan changed the title Updated EIP-1 Update EIP-1 Jun 15, 2021
add link to FEM & add EIP editor
EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Outdated Show resolved Hide resolved
EIPS/eip-1.md Show resolved Hide resolved
@alita-moore alita-moore reopened this Jun 15, 2021
alita-moore and others added 5 commits June 15, 2021 09:47
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Removed a line "No `discussions-to` header is necessary if the EIP is being discussed privately with the author."
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 15, 2021

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

 - Changes to EIP 1 require at least 2 unique approvals from editors, the editors are [@MicahZoltu, @lightclient, @arachnid, @cdetrio, @Souptacular, @vbuterin, @nicksavers, @wanderer, @gcolvin, @axic]

@MicahZoltu @lightclient @Arachnid @cdetrio @Souptacular @vbuterin @nicksavers @wanderer @gcolvin @axic

@alita-moore alita-moore reopened this Jun 16, 2021
@alita-moore alita-moore reopened this Jun 16, 2021
@eth-bot eth-bot enabled auto-merge (squash) June 16, 2021 04:34
@MicahZoltu MicahZoltu disabled auto-merge June 16, 2021 15:16
@alita-moore alita-moore reopened this Jun 17, 2021
@eth-bot eth-bot enabled auto-merge (squash) June 17, 2021 07:53
@MicahZoltu
Copy link
Contributor

Going to merge this, since no one complained in the meeting.

@MicahZoltu MicahZoltu disabled auto-merge June 17, 2021 09:35
@MicahZoltu MicahZoltu enabled auto-merge (squash) June 17, 2021 09:35
@MicahZoltu MicahZoltu disabled auto-merge June 17, 2021 09:35
@MicahZoltu MicahZoltu merged commit f0e228f into ethereum:master Jun 17, 2021
PhABC pushed a commit to PhABC/EIPs that referenced this pull request Jan 25, 2022
* - Updated links - ACD, FEM

- Added EIP editor - Matt Garnett

- recommended to open a discussion thread at FEM (only recommended place)

* Update eip-1.md

add link to FEM & add EIP editor

* Update eip-1.md

* Update eip-1.md

* Update EIPS/eip-1.md

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Update eip-1.md

Removed a line "No `discussions-to` header is necessary if the EIP is being discussed privately with the author."

Co-authored-by: Alita Moore <alita.moore805@gmail.com>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants