1559: Remove deprecated comment #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment is deprecated after ethereum#3681 was merged
|
@MicahZoltu @timbeiko this wasn't reviewed before merging the "final" status update. |
|
Good catch - @abdelhamidbakhta can you approve? |
|
Yeah, I considered blocking merge to final on this PR, but figured since it was a non-normative change it could just merge after final if authors agree to it. |
|
@alita-moore This PR was opened against this EIP when it was Last Call, but then it auto-merged after the base EIP became final. What can we do to prevent that in the future? It should have required editor approval (along with author) to merge. |
|
I suppose the status must always be checked against |
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
The comment is deprecated after ethereum#3681 was merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment is deprecated after #3681 was merged