Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4760: SELFDESTRUCT bomb #4760

Merged
merged 7 commits into from
Mar 26, 2022
Merged

Conversation

dankrad
Copy link
Contributor

@dankrad dankrad commented Feb 3, 2022

Deactivate SELFDESTRUCT by changing it to SENDALL, which does recover all funds to the caller but does not delete any contract code or storage. In order to give applications good time to switch to new constructions, do this via a stage of exponential gas cost increases.

@eth-bot
Copy link
Collaborator

eth-bot commented Feb 3, 2022

All tests passed; auto-merging...

(pass) eip-4760.md

classification
updateEIP
  • passed!

Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with inline suggestions, this needs the following additional sections:

## Security Considerations
All EIPs must contain a section that discusses the security implications/considerations relevant to the proposed change. Include information that might be important for security discussions, surfaces risks and can be used throughout the life cycle of the proposal. E.g. include security-relevant design decisions, concerns, important discussions, implementation-specific guidance and pitfalls, an outline of threats and risks and how they are being addressed. EIP submissions missing the "Security Considerations" section will be rejected. An EIP cannot proceed to status "Final" without a Security Considerations discussion deemed sufficient by the reviewers.

## Copyright
Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).

EIPS/eip-4760.md Outdated Show resolved Hide resolved
EIPS/eip-4760.md Outdated Show resolved Hide resolved
EIPS/eip-4760.md Outdated Show resolved Hide resolved
EIPS/eip-4760.md Outdated Show resolved Hide resolved
EIPS/eip-4760.md Outdated Show resolved Hide resolved
EIPS/eip-4760.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gcolvin gcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for external link issues.

Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to pass CI, which requires shortening the description.

EIPS/eip-4760.md Outdated Show resolved Hide resolved
@eth-bot eth-bot enabled auto-merge (squash) March 26, 2022 08:06
Co-authored-by: Micah Zoltu <micah@zoltu.net>
auto-merge was automatically disabled March 26, 2022 09:05

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) March 26, 2022 09:06
@eth-bot eth-bot merged commit 24f5e0d into ethereum:master Mar 26, 2022
PowerStream3604 pushed a commit to PowerStream3604/EIPs that referenced this pull request May 19, 2022
* Initial commit for SELFDESTRUCT bomb EIP

* Move discussion to Magicians, remove requires from header, add security considerations/copyright

* Summary -> Abstract

* Remove external links

* Proper explanation in rationale

* Fix typo

* Update EIPS/eip-4760.md

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Co-authored-by: Micah Zoltu <micah@zoltu.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants