Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize EIP-2364 #5121

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Finalize EIP-2364 #5121

merged 2 commits into from
Jun 7, 2022

Conversation

Pandapip1
Copy link
Member

CC: @karalabe, @timbeiko

Closes #2365

@eth-bot
Copy link
Collaborator

eth-bot commented Jun 1, 2022

All tests passed; auto-merging...

(pass) eip-2364.md

classification
updateEIP
  • passed!

Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, forkid validation via the discovery protocol requires ENR implementation (EIP-778) and ENR extension support (EIP-868), which is not mandated by the Ethereum network currently. Lastly, the discovery protocol is just one way to find peers, but systems that cannot use UDP or that rely on other mechanism (e.g. DNS discovery (EIP-1459)) still need a way to filter connections.

EIP-1459 is still in review, not final, which means it is blocking this from being merged. Since it is just used as an example, can we just remove it?

Additionally, forkid validation via the discovery protocol requires ENR implementation (EIP-778) and ENR extension support (EIP-868), which is not mandated by the Ethereum network currently. Lastly, the discovery protocol is just one way to find peers, but systems that cannot use UDP or that rely on other mechanism (e.g. DNS discovery) still need a way to filter connections.

@Pandapip1 Pandapip1 requested a review from MicahZoltu June 4, 2022 13:06
@MicahZoltu
Copy link
Contributor

@timbeiko Can you review/approve again? The reference to EIP-1459 was removed and I would like to get author sign-off on that change before approving.

@MicahZoltu MicahZoltu closed this Jun 7, 2022
@MicahZoltu MicahZoltu reopened this Jun 7, 2022
@eth-bot eth-bot enabled auto-merge (squash) June 7, 2022 06:47
@eth-bot eth-bot merged commit b69b44a into ethereum:master Jun 7, 2022
@Pandapip1 Pandapip1 deleted the patch-11 branch June 7, 2022 10:45
@Pandapip1 Pandapip1 mentioned this pull request Jun 9, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* Finalize EIP-2364

* Remove reference to non-final EIP
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIP-2364: eth/64: forkid-extended protocol handshake
4 participants