-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize EIP-2364 #5121
Finalize EIP-2364 #5121
Conversation
All tests passed; auto-merging...(pass) eip-2364.md
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally,
forkid
validation via the discovery protocol requires ENR implementation (EIP-778) and ENR extension support (EIP-868), which is not mandated by the Ethereum network currently. Lastly, the discovery protocol is just one way to find peers, but systems that cannot use UDP or that rely on other mechanism (e.g. DNS discovery (EIP-1459)) still need a way to filter connections.
EIP-1459 is still in review, not final, which means it is blocking this from being merged. Since it is just used as an example, can we just remove it?
Additionally,
forkid
validation via the discovery protocol requires ENR implementation (EIP-778) and ENR extension support (EIP-868), which is not mandated by the Ethereum network currently. Lastly, the discovery protocol is just one way to find peers, but systems that cannot use UDP or that rely on other mechanism (e.g. DNS discovery) still need a way to filter connections.
@timbeiko Can you review/approve again? The reference to EIP-1459 was removed and I would like to get author sign-off on that change before approving. |
* Finalize EIP-2364 * Remove reference to non-final EIP
CC: @karalabe, @timbeiko
Closes #2365