Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-158: Update wording #5588

Closed
wants to merge 1 commit into from
Closed

Update EIP-158: Update wording #5588

wants to merge 1 commit into from

Conversation

fulldecent
Copy link
Contributor

Updates wording to remove reference to a deprecated word

@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Sep 4, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 4, 2022 •
edited
Loading

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) eip-158.md

classification
updateEIP
  • eip-158.md requires approval from one of (@vbuterin)

@Pandapip1 Pandapip1 changed the title Update wording Update EIP-158: Update wording Sep 4, 2022
@Pandapip1 Pandapip1 added this to the Manual Merge Queue milestone Sep 4, 2022
Pandapip1
Pandapip1 approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me

xinbenlv
xinbenlv approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamWilsn
Copy link
Contributor

While I do agree we should be sensitive to these issues, I think we should keep existing EIPs as-written, and encourage future EIPs to use the correct terminology.

One issue is that if we replaced all "suicide" occurrences with "self-destruct" everywhere, EIP-6 would no longer make sense.

@SamWilsn SamWilsn mentioned this pull request Sep 12, 2022
Closed
@SamWilsn
Copy link
Contributor

Perhaps we could come to a solution that doesn't require editing the EIPs? Perhaps have Jekyll put up a warning on pages containing the word?

@Pandapip1 Pandapip1 added the a-review Waiting on author to review label Sep 12, 2022
@Pandapip1 Pandapip1 removed this from the Manual Merge Queue milestone Sep 12, 2022
@poojaranjan poojaranjan mentioned this pull request Nov 14, 2022
Closed
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Nov 22, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinbenlv xinbenlv xinbenlv approved these changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-final This EIP is Final t-core w-stale Waiting on activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fulldecent @eth-bot @SamWilsn @xinbenlv @Pandapip1