Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-5851: On-Chain Verifiable Credentials #5851

Merged
merged 134 commits into from
Jan 15, 2023
Merged

Add EIP-5851: On-Chain Verifiable Credentials #5851

merged 134 commits into from
Jan 15, 2023

Conversation

dhruvmalik007
Copy link
Contributor

@dhruvmalik007 dhruvmalik007 commented Oct 29, 2022 •
edited
Loading

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Authors : Dhruv Malik (@dhruvmalik007 ), Yu-LIU(@yuliu-debond ) and Junyi Zhong (@Jooeys).

@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft labels Oct 29, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 29, 2022 •
edited
Loading

A critical exception has occurred:
Message: pr 5851 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

@github-actions github-actions bot added t-erc and removed e-number Waiting on EIP Number assignment labels Oct 29, 2022
@Pandapip1 Pandapip1 changed the title ERC standard for issuing and verifying identity certificates. Add EIP-5851: ZK-based-KYC-certificates Oct 30, 2022
Pandapip1
Pandapip1 suggested changes Oct 30, 2022
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my review so far. It's incomplete, but I had to stop partway through it.

EIPS/eip-5851.md Outdated Show resolved Hide resolved
EIPS/eip-5851.md Outdated Show resolved Hide resolved
EIPS/eip-5851.md Outdated Show resolved Hide resolved
EIPS/eip-5851.md Outdated Show resolved Hide resolved
EIPS/eip-5851.md Outdated Show resolved Hide resolved
EIPS/eip-5851.md Outdated Show resolved Hide resolved
EIPS/eip-5851.md Outdated Show resolved Hide resolved
EIPS/eip-5851.md Show resolved Hide resolved
EIPS/eip-5851.md Outdated Show resolved Hide resolved
EIPS/eip-5851.md Outdated Show resolved Hide resolved
dhruvmalik007 and others added 4 commits October 30, 2022 15:33
@dhruvmalik007 @Pandapip1
Update spaces in-lining
794ba6b 
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@dhruvmalik007 @Pandapip1
link and image format
e31b4aa 
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@dhruvmalik007 @Pandapip1
defining definition of ZK term
e54891b 
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@dhruvmalik007 @Pandapip1
Refactoring the description
2ec7da5 
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@github-actions github-actions bot removed t-erc s-draft This EIP is a Draft labels Jan 10, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 10, 2023
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Jan 10, 2023
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jan 10, 2023
@yuliu-debond
Copy link
Contributor

@Jooeys @SamWilsn @Pandapip1
I recovered the old version of the eip-3475, and updated the eip-5851 file to the latest version.

yuliu-debond
yuliu-debond previously approved these changes Jan 10, 2023
View reviewed changes
@github-actions
Copy link

The commit 05c2d86 (as a parent of 50cfcf3) contains errors.
Please inspect the Run Summary for details.

Pandapip1
Pandapip1 previously requested changes Jan 10, 2023
View reviewed changes
assets/eip-5851/contracts/ERC5851Issuer.sol
@@ -0,0 +1,46 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the EIP-3475 changes in a separate PR.

Copy link
Contributor

@Jooeys Jooeys Jan 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Pandapip1 can you approve this version,now EIP-3475 file stay unchanged.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jan 10, 2023
@dhruvmalik007 dhruvmalik007 changed the title Add EIP-5851: Zero-Knowledge KYC Certificates Add EIP-5851: Jan 11, 2023
@dhruvmalik007 dhruvmalik007 changed the title Add EIP-5851: Add EIP-5851: Add to draft status Jan 11, 2023
@dhruvmalik007 dhruvmalik007 changed the title Add EIP-5851: Add to draft status Add EIP-5851: On-Chain Verifiable Credentials Jan 12, 2023
@Pandapip1 Pandapip1 enabled auto-merge (squash) January 13, 2023 19:42
@Pandapip1 Pandapip1 merged commit 2504208 into ethereum:master Jan 15, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlace0x zlace0x zlace0x left review comments

@Jooeys Jooeys Jooeys approved these changes

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot eth-bot approved these changes

@Pandapip1 Pandapip1 Pandapip1 left review comments

@yuliu-debond yuliu-debond yuliu-debond left review comments

Assignees
No one assigned
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dhruvmalik007 @eth-bot @Jooeys @yuliu-debond @SamWilsn @Pandapip1 @zlace0x @remedcu