Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-5902: Smart Contract Event Hooks #5902

Merged
merged 12 commits into from
Dec 26, 2022
Merged

Add EIP-5902: Smart Contract Event Hooks #5902

merged 12 commits into from
Dec 26, 2022

Conversation

orbmis
Copy link
Contributor

@orbmis orbmis commented Nov 9, 2022

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@orbmis orbmis requested a review from eth-bot as a code owner November 9, 2022 10:47
@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-erc labels Nov 9, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 9, 2022 •
edited
Loading

All tests passed; auto-merging...

(pass) eip-5902.md

classification
updateEIP
  • passed!

@github-actions github-actions bot removed the e-number Waiting on EIP Number assignment label Nov 9, 2022
@Pandapip1 Pandapip1 changed the title Orbmis/eip 5897 smart contract event hooks standard Add EIP-5897: Smart Contract Event Hooks Nov 9, 2022
Pandapip1
Pandapip1 suggested changes Nov 9, 2022
View reviewed changes
EIPS/eip-5897.md Outdated Show resolved Hide resolved
@orbmis orbmis requested a review from Pandapip1 November 9, 2022 15:31
@orbmis orbmis changed the title Add EIP-5897: Smart Contract Event Hooks Add EIP-5902: Smart Contract Event Hooks Nov 9, 2022
xinbenlv
xinbenlv reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very interesting EIP. Thank you for your authoring. Will take a look

@orbmis
Copy link
Contributor Author

orbmis commented Nov 10, 2022

This is a very interesting EIP. Thank you for your authoring. Will take a look

Thanks @xinbenlv . I fear it's not that obvious how subtly different this is from existing alternatives so I'm happy to answer any questions.

@poojaranjan poojaranjan mentioned this pull request Nov 15, 2022
Closed
@Pandapip1 Pandapip1 closed this Dec 26, 2022
@Pandapip1 Pandapip1 reopened this Dec 26, 2022
@eth-bot eth-bot enabled auto-merge (squash) December 26, 2022 16:19
@eth-bot eth-bot merged commit 7cac73f into ethereum:master Dec 26, 2022
@orbmis orbmis deleted the orbmis/EIP-5897_smart-contract-event-hooks-standard branch January 17, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinbenlv xinbenlv xinbenlv left review comments

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@orbmis @eth-bot @xinbenlv @Pandapip1