Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5192: Change name to "Lockable tokens" #6330

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions EIPS/eip-5192.md
@@ -1,7 +1,7 @@
---
eip: 5192
title: Minimal Soulbound NFTs
description: Minimal interface for soulbinding EIP-721 NFTs
title: Lockable NFTs
description: Minimal interface for lockable EIP-721 NFTs
author: Tim Daubenschütz (@TimDaub), Anders (@0xanders)
discussions-to: https://ethereum-magicians.org/t/eip-5192-minimal-soulbound-nfts/9814
status: Final
Expand All @@ -13,7 +13,7 @@ requires: 165, 721

## Abstract

This standard is an extension of [EIP-721](./eip-721.md). It proposes a minimal interface to make tokens soulbound using the feature detection functionality of [EIP-165](./eip-165.md). A soulbound token is a non-fungible token bound to a single account.
This standard is an extension of [EIP-721](./eip-721.md). It proposes a minimal interface to make tokens lockable using the feature detection functionality of [EIP-165](./eip-165.md). A lockable token is a non-fungible token bound to a single account.

## Motivation

Expand Down Expand Up @@ -44,19 +44,19 @@ interface IERC5192 {
/// @param tokenId The identifier for a token.
event Unlocked(uint256 tokenId);

/// @notice Returns the locking status of an Soulbound Token
/// @dev SBTs assigned to zero address are considered invalid, and queries
/// @notice Returns the locking status of a token
/// @dev Tokens assigned to zero address are considered invalid, and queries
/// about them do throw.
/// @param tokenId The identifier for an SBT.
/// @param tokenId The identifier for a token.
function locked(uint256 tokenId) external view returns (bool);
}
```

To aid recognition that an [EIP-721](./eip-721.md) token implements "soulbinding" via this EIP upon calling [EIP-721](./eip-721.md)'s `function supportsInterface(bytes4 interfaceID) external view returns (bool)` with `interfaceID=0xb45a3c0e`, a contract implementing this EIP must return `true`.
To aid recognition that an [EIP-721](./eip-721.md) token implements locking via this EIP upon calling [EIP-721](./eip-721.md)'s `function supportsInterface(bytes4 interfaceID) external view returns (bool)` with `interfaceID=0xb45a3c0e`, a contract implementing this EIP must return `true`.

## Rationale

The above model is the simplest possible path towards a canonical interface for Soulbound tokens. It reflects upon the numerous Soulbound token implementations that simply revert upon transfers.
The above model is the simplest possible path towards a canonical interface for locking tokens. It reflects upon the numerous "Soulbound token" implementations that simply revert upon transfers.

## Backwards Compatibility

Expand Down