Add EIP: Support ENS Name for Web3 URL #6821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
|
✅ All reviewers have approved. |
eth-bot
added
e-consensus
qizhou
changed the title
eth-bot
changed the title
|
The commit 4eefa1d (as a parent of b98bddd) contains errors. |
16 tasks
SamWilsn
reviewed
Apr 4, 2023
EIPS/eip-6821.md
Outdated
| type: Standards Track | ||
| category: ERC | ||
| created: 2023-04-02 | ||
| requires: 137, 4804 |
There was a problem hiding this comment.
Should this standard reference https://eips.ethereum.org/EIPS/eip-634?
There was a problem hiding this comment.
Added. One question is that EIP-634 is in stagnant status, which prevents finalizing the standard. Do you have any thoughts on that?
There was a problem hiding this comment.
It's kinda unfortunate. Might be worth opening a PR to bring 634 out of stagnant.
There was a problem hiding this comment.
I make a PR for this #6841
23 tasks
SamWilsn
reviewed
May 4, 2023
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
SamWilsn
approved these changes
May 5, 2023
eth-bot
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: