Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-634: Move to Last Call #6841

Closed
wants to merge 3 commits into from
Closed

Conversation

qizhou
Copy link
Contributor

@qizhou qizhou commented Apr 6, 2023

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@qizhou qizhou requested a review from eth-bot as a code owner April 6, 2023 02:04
@github-actions github-actions bot added c-status Changes a proposal's status t-erc labels Apr 6, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 6, 2023

File EIPS/eip-634.md

Requires 1 more reviewers from @ricmoo

@eth-bot eth-bot changed the title Move eip-634 to last call Update EIP-634: Move to Last Call Apr 6, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label Apr 6, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 6, 2023
SamWilsn
SamWilsn previously approved these changes May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

The commit eff2774 (as a parent of c738017) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 5, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added w-stale Waiting on activity and removed w-stale Waiting on activity labels Sep 16, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Oct 1, 2023
@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 25, 2023
@ricmoo
Copy link
Contributor

ricmoo commented Oct 25, 2023

Thanks for the info. I may also just move this to the ENSIP repo instead. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-status Changes a proposal's status t-erc w-stale Waiting on activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants