Update EIP-5725: Move to Last Call #7180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed eipw errors
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Rename IVestingNFT to IERC5725
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
refactor: Consistent style and event description
chore: Commit draft EIP
|
✅ All reviewers have approved. |
|
|
11 tasks
SamWilsn
reviewed
Aug 22, 2023
[feat] Add allowance feature to EIP-5725
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
|
@SamWilsn Thanks so much for the review! 🙏 I have update the last call date to your recommended. |
SamWilsn
requested changes
Aug 28, 2023
|
@SamWilsn thx for catching that. 🙏 All comments resolved. 🥳 |
SamWilsn
approved these changes
Aug 29, 2023
eth-bot
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last Callwill last until Friday September 5th, 2023