Update EIP-7401: Move to Review #7414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-status
|
✅ All reviewers have approved. |
The proposal's number was updated to reflect it being a fix of ERC-6059.
github-actions
bot
removed
c-status
21 tasks
1 task
SamWilsn
reviewed
Aug 9, 2023
github-actions
bot
added
c-status
11 tasks
SamWilsn
approved these changes
Aug 22, 2023
Comment on lines
+14
to
+19
| > :information_source: **[ERC-7401](./eip-7401.md) has superseded [ERC-6059](./eip-6059.md).** :information_source: | ||
| > [ERC-7401](./eip-7401.md) fixes the inconsistency in the [ERC-6059](./eip-6059.md) interface specification, where interface ID doesn't match the interface specified as the interface evolved during the proposal's lifecycle, but one of the parameters was not added to it. The missing parameter is, however, present in the interface ID. | ||
| > Apart from this fix, [ERC-7401](./eip-7401.md) is functionally equivalent to [ERC-6059](./eip-6059.md). | ||
| > | ||
| > :warning: [ERC-7401](./eip-7401.md) MUST be used in lieu of [ERC-6059](./eip-6059.md). :warning: | ||
|
|
There was a problem hiding this comment.
:information_source: doesn't actually render to anything. I guess use an emoji?
I'd prefer this to be moved into the motivation section, but I won't be too strict about that.
eth-bot
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the status of EIP-7401 to Review stage.