Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: EOF - Data section access instructions #7480

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Aug 11, 2023

No description provided.

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Aug 11, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 11, 2023

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Aug 11, 2023
@github-actions
Copy link

The commit 2352fbc (as a parent of f2685f3) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Aug 11, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Aug 11, 2023
@eth-bot eth-bot changed the title Add EIP: EOF - Data instructions Add EIP: EOF - Data section access instructions Aug 14, 2023

## Specification

We introduce four new instructions on the same block number [EIP-3540](./eip-3540.md) is activated on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it would be better to specify activation independently (and this EIP already specifies that it depends on 3540). Their activation is dependent on inclusion of the EIP in a particular hardfork which would be an independent decision by the ACD.

Suggested change
We introduce four new instructions on the same block number [EIP-3540](./eip-3540.md) is activated on:
We introduce four new instructions:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of EOF must be activated at the same time, otherwise the functionality is very limited.

EIPS/eip-7480.md Outdated Show resolved Hide resolved
@gumb0 gumb0 marked this pull request as ready for review September 22, 2023 13:03
@gumb0 gumb0 requested a review from eth-bot as a code owner September 22, 2023 13:03
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eth-bot eth-bot enabled auto-merge (squash) September 22, 2023 16:58
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 55cf6b8 into ethereum:master Sep 22, 2023
13 of 16 checks passed
@gumb0 gumb0 deleted the eof-data-instructions branch September 22, 2023 16:58
@ProphetZX
Copy link

Just a short question: Why do you plan to implement a DATALOAD and DATALOADN method/function? Is it as a backup version, so if either gets rejected in a specific situation, you‘d want to switch to the other one?

@ProphetZX
Copy link

Just have some doubts it‘s really necessary. :)

@gumb0
Copy link
Member Author

gumb0 commented Sep 22, 2023

Just a short question: Why do you plan to implement a DATALOAD and DATALOADN method/function? Is it as a backup version, so if either gets rejected in a specific situation, you‘d want to switch to the other one?

It's in Motivation:

DATALOADN is an optimized version of DATALOAD, where data offset to read is set at compilation time, and therefore need not be validated at run-time, which makes the instruction cheaper.

DATALOADN can be used when the offset is known at compile-time, DATALOAD is needed to read from offset determined at run-time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants