-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: EOF - Data section access instructions #7480
Conversation
✅ All reviewers have approved. |
The commit 2352fbc (as a parent of f2685f3) contains errors. |
9e6d4e6
to
961a196
Compare
|
||
## Specification | ||
|
||
We introduce four new instructions on the same block number [EIP-3540](./eip-3540.md) is activated on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it would be better to specify activation independently (and this EIP already specifies that it depends on 3540). Their activation is dependent on inclusion of the EIP in a particular hardfork which would be an independent decision by the ACD.
We introduce four new instructions on the same block number [EIP-3540](./eip-3540.md) is activated on: | |
We introduce four new instructions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of EOF must be activated at the same time, otherwise the functionality is very limited.
18b0952
to
4277921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Just a short question: Why do you plan to implement a DATALOAD and DATALOADN method/function? Is it as a backup version, so if either gets rejected in a specific situation, you‘d want to switch to the other one? |
Just have some doubts it‘s really necessary. :) |
It's in Motivation:
|
No description provided.