Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7329: Move to Final #7718

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Update EIP-7329: Move to Final #7718

merged 1 commit into from
Sep 19, 2023

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Sep 14, 2023

No substantive changes were made or requested, all changes from last call were minor to stylistic.

No substative changes were made or requested, all changes from last call were minor to stylistic.
@github-actions github-actions bot added c-status Changes a proposal's status s-final This EIP is Final t-meta labels Sep 14, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 14, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Move to final. Update EIP-7329: Move to Final Sep 14, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Sep 14, 2023
@xinbenlv
Copy link
Contributor

Should this EIP be "Final" when the repo hardfork is live? (just like the Core EIP)

@shemnon
Copy link
Contributor Author

shemnon commented Sep 14, 2023

I wasn't sure which was blocking which, and I got a request to post a PR to move it to final.

I'm OK with it being merged after the repo fork occurs. But the last call for comments has closed.

@xinbenlv
Copy link
Contributor

Yeah, I agree the Last Call window has passed and can be closed

@eth-bot eth-bot enabled auto-merge (squash) September 19, 2023 14:56
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 7ff802d into ethereum:master Sep 19, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-final This EIP is Final t-meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants