Adding co-author of ERC55 #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Vitalik initially proposed the idea it was quite different, using the binary form of the address, which added complexity. I created the first implementation in that form, and suggested the simplified version `If it's 8 or upper (including a-f) then it should be uppercase, otherwise, it should be lowercase.` I also pushed the first implementations. His original post has been edited by EIP editors as we didn't have the PR format yet. Would that be enough to be a co-author? I don't mind if this is rejected, just wanted to point that up.
|
The JavaScript implementation on this page https://eips.ethereum.org/EIPS/eip-55 seems to come from this comment #55 (comment). And the idea to change from using binary form to the visible address also came from you, so it seems reasonable to me. Since @vbuterin didn't create the PR himself, only the issue which clearly had a lot of discussion before coming to a conclusion I'll merge this. |
ilanolkies
pushed a commit
to ilanolkies/EIPs
that referenced
this pull request
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Vitalik initially proposed the idea it was quite different, using the binary form of the address, which added complexity. I created the first implementation in that form, and suggested the simplified version
If it's 0-7 then it should be lowercase, otherwise, it should be uppercase.I also pushed the first implementations. His original post has been edited by EIP editors as we didn't have the PR format yet.Would that be enough to be a co-author? I don't mind if this is rejected, just wanted to point that up.