Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eipw fails to resolve requires in preamble #46

Closed
tbergmueller opened this issue Oct 27, 2023 · 6 comments
Closed

eipw fails to resolve requires in preamble #46

tbergmueller opened this issue Oct 27, 2023 · 6 comments
Labels
bug Something isn't working w-stale

Comments

@tbergmueller
Copy link
Contributor

tbergmueller commented Oct 27, 2023

Pull Request

No response

What happened?

I assume this is an additional problem, adding to #45

When Walidator verifies the preamble, in the requires: 165, 721 it tries to open ERCS/eip-165.md and ERCS/eip-721.md.
This should rather be ERCs/erc-165.md and ERCs/erc-721.md`

Observed here:
46ed905

image

Relevant log output

No response

@tbergmueller tbergmueller added the bug Something isn't working label Oct 27, 2023
@tbergmueller tbergmueller changed the title Walidator fails to resolve requires Walidator fails to resolve requires in preamble Oct 27, 2023
@Joachim-Lebrun
Copy link
Contributor

Joachim-Lebrun commented Oct 27, 2023

As discussed here, it would maybe even make sense to adapt the preamble section to ERCs now that the split happened, the preamble section as defined in EIP-1 makes sense if you have a repository containing both EIPs and ERCs but doesn't make sense anymore as soon as you split

@SamWilsn SamWilsn changed the title Walidator fails to resolve requires in preamble eipw fails to resolve requires in preamble Nov 1, 2023
Copy link

github-actions bot commented Nov 9, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@ra-phael
Copy link
Contributor

I also have this error in https://github.com/ethereum/ERCs/pull/92/files
What is the best way to proceed?

@github-actions github-actions bot removed the w-stale label Nov 24, 2023
@Pandapip1
Copy link
Member

CC @SamWilsn to move this into the eipw repo

Copy link

github-actions bot commented Dec 7, 2023

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

Copy link

This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working w-stale
Projects
None yet
Development

No branches or pull requests

4 participants