Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Added bootnodes for Rinkeby and Goerli #5634

Merged
merged 3 commits into from
Jun 20, 2019
Merged

Added bootnodes for Rinkeby and Goerli #5634

merged 3 commits into from
Jun 20, 2019

Conversation

nrednav
Copy link

@nrednav nrednav commented Jun 18, 2019

This was requested here: #5629

I also:-

  • Added the Ethereum Foundation's C++ bootnode for the Mainnet
  • Added bootnode locations as comments, for Mainnet and Ropsten, as seen in Geth's bootnode list

2) Added Ethereum Foundation's C++ bootnode for the Mainnet
3) Added bootnode locations as comments, for Mainnet and Ropsten, as seen in Geth's bootnode list
@halfalicious
Copy link
Contributor

@nrednav Thank you for your contribution 😄 Can you please also add a changelog entry to CHANGELOG.md: https://github.com/ethereum/aleth/blob/master/CHANGELOG.md

(Please add an "added" entry under the rest of the "added" entries here)

@nrednav
Copy link
Author

nrednav commented Jun 20, 2019

@nrednav Thank you for your contribution 😄 Can you please also add a changelog entry to CHANGELOG.md: https://github.com/ethereum/aleth/blob/master/CHANGELOG.md

(Please add an "added" entry under the rest of the "added" entries here)

Hi, I'm quite new to all of this, would I submit another pull request after adding that entry to the changelog?

@chfast
Copy link
Member

chfast commented Jun 20, 2019

Make a new commit with the Changelog change and push it to the same branch.

@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #5634 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5634      +/-   ##
==========================================
- Coverage   62.77%   62.74%   -0.03%     
==========================================
  Files         348      348              
  Lines       29648    29657       +9     
  Branches     3341     3341              
==========================================
- Hits        18612    18609       -3     
- Misses       9821     9830       +9     
- Partials     1215     1218       +3

@nrednav
Copy link
Author

nrednav commented Jun 20, 2019

Make a new commit with the Changelog change and push it to the same branch.

Done, thank you : )

It's outdated, I don't think it's alive anymore.
@gumb0
Copy link
Member

gumb0 commented Jun 20, 2019

I removed "Ethereum Foundation C++ Bootnode" as I don't think it's alive anymore.
(I tried it and it doesn't answer to Ping)

@gumb0 gumb0 merged commit 5c639f8 into ethereum:master Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants