Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capital letters for constants, spaces between functions #89

Merged
merged 5 commits into from
Apr 18, 2018
Merged

Capital letters for constants, spaces between functions #89

merged 5 commits into from
Apr 18, 2018

Conversation

lounlee
Copy link
Contributor

@lounlee lounlee commented Apr 17, 2018

tried to address #88

@lounlee
Copy link
Contributor Author

lounlee commented Apr 17, 2018

working on test codes..

ChihChengLiang
ChihChengLiang reviewed Apr 17, 2018
View reviewed changes
casper/contracts/simple_casper.v.py Outdated
self.base_interest_factor = _base_interest_factor
self.base_penalty_factor = _base_penalty_factor
self.min_deposit_size = _min_deposit_size
_EPOCH_LENGTH: int128, _WITHDRAWAL_DELAY: int128, _DYNASTY_LOGOUT_DELAY: int128,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need to capitalize these function parameters.

Copy link
Contributor

@ChihChengLiang ChihChengLiang Apr 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asked the sharding smc developer @NIC619 , the uppercased function parameters are not part of any style guide. so lower_case_with_underscores without leading underscore is advisable here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll change it.

@djrtwo
Copy link
Contributor

djrtwo commented Apr 17, 2018

@beneficial02 Have you been able to setup your local environment for testing? The README doesn't explain.. I can give you a hand if you need :)

@lounlee
Copy link
Contributor Author

lounlee commented Apr 17, 2018 •
edited
Loading

Thanks for the kind words! I did pip install -r requirements.txt and ran test codes with pytest tests.

misc/test_rando.py gives me FileNotFoundError but it gives me the same error with the status of this commit so I judged this is not because of my modification.

So I finished to change the test codes and it passes all the tests except test_rando.py. Please correct me if my approach is wrong.

@ChihChengLiang
Copy link
Contributor

you should skip test_rando.py. but pytest tests/ should already help you to do that.

@lounlee
Copy link
Contributor Author

lounlee commented Apr 17, 2018

Yes pytest tests/ skipped test_rando.py but I mentioned it just in case :)

@djrtwo
Copy link
Contributor

djrtwo commented Apr 17, 2018

Yeah.. the repo has a lot of extra bits of code left over from previous iterations. Need to clean it up some time..

@djrtwo
Copy link
Contributor

djrtwo commented Apr 18, 2018

LGTM!

@djrtwo djrtwo merged commit 2f6ee48 into ethereum:master Apr 18, 2018
@djrtwo djrtwo mentioned this pull request Apr 18, 2018
Closed
@lounlee lounlee deleted the var_name_func_spaces branch April 18, 2018 01:35
@djrtwo djrtwo mentioned this pull request Apr 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lounlee @djrtwo @ChihChengLiang