Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid transfer sanity test #1147

Closed
sorpaas opened this issue Jun 7, 2019 · 2 comments
Closed

Invalid transfer sanity test #1147

sorpaas opened this issue Jun 7, 2019 · 2 comments
Labels
scope:CI/tests/pyspec

Comments

@sorpaas
Copy link

sorpaas commented Jun 7, 2019

For all our config the MAX_TRANSFERS value is 0. However, we have tests that contain transfer, and it's expected to not error!
@sorpaas sorpaas mentioned this issue Jun 7, 2019
Merged
@JustinDrake
Copy link
Collaborator

JustinDrake commented Jun 8, 2019 •
edited
Loading

It may be clearer for testability to move the contents of process_transfer to the phase 1 doc, and move the corresponding tests. I'd even argue to remove the transfers field from BeaconBlockBody (it's cleaner, see item 8 in #1054) but @djrtwo disagrees :)

@djrtwo
Copy link
Contributor

djrtwo commented Jun 13, 2019

In v0.7.0, the block tests for transfer are removed but the tests for process_transfer remain as these are isolated from the block operation size checks.

Will keep it in this state until we decide how we want to test forks. Then we'll have a fork test that tests changing config to activate transfers

@djrtwo djrtwo closed this as completed Jun 13, 2019
@sorpaas sorpaas mentioned this issue Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JustinDrake @djrtwo @sorpaas @hwwhww