-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve beacon proposer selection logic #1371
Conversation
Co-Authored-By: Carl Beekhuizen <carl@ethereum.org>
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
Co-Authored-By: Hsiao-Wei Wang <hwwang156@gmail.com>
…ount and committee size not equal
Update `unpack_compact_validator` in sync protocol
Remove bug bitlist length checks in process_attestation
Starting on phase 1 misc beacon changes
This needs adjustments to the validator guide (being part of a committee is no longer a warning of potential proposal) and I want to run a couple of tests on the min-validator requirement of the chain now. I'm a little resistant to the change due to the spec freeze especially since we don't really have a criteria for evaluating if something like this should go in other than "it's better". |
Added misc beacon chain updates to ToC
Why not put this under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the v-guide accordingly.
Confirmed that a lot more of the tests pass with less than SLOTS_PER_EPOCH
vals, but haven't fully confirmed the low val count. Too many of our tests assume there is a committee available at a slot to make attestations (which is a sane way to test in general). Have on my todo to add some tests for handling empty operations and things.
Last thing here: I don't think we can do the filter in get_beacon_proposer_index
by slashed
. That would remove the predictable property within an epoch
Bump on my above comment
Looking for an agreement and then I'll merge this |
👍
Oh right :) On that note |
Closing in favor of #1413 |
Sample proposer from the full set of active validators (as opposed to just the first committee) and make proposer slashing per-slot (as opposed to per-epoch).
SLOTS_PER_EPOCHS
, an unintended design flaw). Improved liveness with low validator count may be useful for testing, fuzzing, and private consortium beacon chains.get_committee_count
,get_start_shard
andget_crosslink_committee
. Reduceget_beacon_proposer_index
line count by 20% (from 15 lines to 12 lines).Edit: I've abstracted away
compute_proposer_index
for reuse in phase 1.