Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add payload id as a return value to notify_forkchoice_updated #2711

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Add payload id as a return value to notify_forkchoice_updated #2711

merged 2 commits into from
Nov 4, 2021

Conversation

mkalinin
Copy link
Collaborator

@mkalinin mkalinin commented Nov 4, 2021

  • Adds Optional[PayloadId] as a return value to the notify_forkchoice_updated function
  • Removes redundant get_payload_id function

Relates to ethereum/execution-apis#109

@mkalinin mkalinin mentioned this pull request Nov 4, 2021
Merged
1 task
djrtwo
djrtwo approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup!

@djrtwo djrtwo merged commit 28af334 into ethereum:dev Nov 4, 2021
@dapplion dapplion mentioned this pull request Nov 4, 2021
Closed
24 tasks
@g11tech g11tech mentioned this pull request Nov 5, 2021
Merged
14 tasks
@tbenr tbenr mentioned this pull request Nov 8, 2021
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

@ralexstokes ralexstokes Awaiting requested review from ralexstokes

@protolambda protolambda Awaiting requested review from protolambda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkalinin @djrtwo