Silently skip deposits with invalid proof in process_deposit #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuterin
reviewed
Feb 9, 2019
vbuterin
reviewed
Feb 9, 2019
…d_proof` variable contains a valid proof as opposed to just being a bool. Co-Authored-By: Nashatyrev <Nashatyrev@users.noreply.github.com>
…d_proof` variable contains a valid proof as opposed to just being a bool. Co-Authored-By: Nashatyrev <Nashatyrev@users.noreply.github.com>
djrtwo
approved these changes
Feb 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's wrong:
process_deposithas thestatement which aborts processing of the block containing a deposit with invalid proof resulting this block being invalid.
Thus a proposer needs to skip deposits with invalid proofs when composing a block. The same way malicious/incorrect proposer may skip a number of valid deposits.
Suggestion:
Include all deposits to blocks (this is verified by constantly incremented deposit index) but silently ignore deposits with invalid proofs on block transition: i.e. not change the validator registry/balances