Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silently skip deposits with invalid proof in process_deposit #589

Merged
merged 4 commits into from
Feb 9, 2019
Merged

Silently skip deposits with invalid proof in process_deposit #589

merged 4 commits into from
Feb 9, 2019

Commits on Feb 8, 2019

  1. Silently skip deposits with invalid proof in process_deposit

    @Nashatyrev
    Nashatyrev committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    f9eaab1 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2019

  1. Change var name to avoid confusing the reader into thinking the `vali… 

    …d_proof` variable contains a valid proof as opposed to just being a bool.

Co-Authored-By: Nashatyrev <Nashatyrev@users.noreply.github.com>
    @vbuterin @Nashatyrev
    vbuterin and Nashatyrev committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    0157aa0 View commit details
    Browse the repository at this point in the history

  2. Change var name to avoid confusing the reader into thinking the `vali… 

    …d_proof` variable contains a valid proof as opposed to just being a bool.

Co-Authored-By: Nashatyrev <Nashatyrev@users.noreply.github.com>
    @vbuterin @Nashatyrev
    vbuterin and Nashatyrev committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    e48010b View commit details
    Browse the repository at this point in the history

  3. change proof_is_valid to exit condition

    @djrtwo
    djrtwo committed Feb 9, 2019
    Configuration menu
    Copy the full SHA
    7886d96 View commit details
    Browse the repository at this point in the history