fix off by one attestaton issue #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @arnetheduck |
JustinDrake
approved these changes
Feb 14, 2019
Done! :) |
|
what a beauty! :) |
This was referenced Feb 15, 2019
hwwhww
added a commit
to hwwhww/trinity
that referenced
this pull request
Feb 22, 2019
hwwhww
added a commit
to hwwhww/trinity
that referenced
this pull request
Feb 22, 2019
hwwhww
added a commit
to ethereum/trinity
that referenced
this pull request
Feb 24, 2019
* Update privkeys fixtures, thanks to VB * Address ethereum/consensus-specs#672: fix up previous epoch logic around genesis * Address ethereum/consensus-specs#627: fix off by one attestaton issue * Fix attester tools 1. Fix `create_mock_signed_attestation`: Address ethereum/consensus-specs#671 2. Fix `test_demo.py` 1. Use queued `attestations_map: Dict[Slot, Sequence[Attestation]]` to keep the generated attestations, and include them when reache `MIN_ATTESTATION_INCLUSION_DELAY`. 2. Add justification assertions * PR feedback * PR feedback
ralexstokes
added a commit
to ralexstokes/trinity
that referenced
this pull request
Apr 8, 2019
this seems to be feasible now that we are removing the 'attestation kludge' ethereum/consensus-specs#627
ralexstokes
added a commit
to ralexstokes/trinity
that referenced
this pull request
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #618
Note that this is the quick fix. There is a discussion to be had on when exactly the epoch transition should occur. An alternative would be to be at the start of the 0th slot of an epoch rather than at the end of the last slot of an epoch. I'd like to get this fix merged now for the spec release because this is a critical bug and can save any debate for over this next week.