Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator guide bug fixes #671

Merged
merged 3 commits into from
Feb 22, 2019
Merged

validator guide bug fixes #671

merged 3 commits into from
Feb 22, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Feb 21, 2019

addresses #628 and #652

note: the validator guide needs a bit of reworking wrt how to handle empty slots but this will come in a separate PR

@djrtwo djrtwo requested a review from hwwhww February 21, 2019 22:20
hwwhww added a commit to hwwhww/trinity that referenced this pull request Feb 22, 2019
1. Fix `create_mock_signed_attestation`: Address ethereum/consensus-specs#671
2. Fix `test_demo.py`
	1. Use queued `attestations_map: Dict[Slot, Sequence[Attestation]]` to keep the generated attestations, and include them when reache `MIN_ATTESTATION_INCLUSION_DELAY`.
	2. Add justification assertions
hwwhww added a commit to hwwhww/trinity that referenced this pull request Feb 22, 2019
1. Fix `create_mock_signed_attestation`: Address ethereum/consensus-specs#671
2. Fix `test_demo.py`
	1. Use queued `attestations_map: Dict[Slot, Sequence[Attestation]]` to keep the generated attestations, and include them when reache `MIN_ATTESTATION_INCLUSION_DELAY`.
	2. Add justification assertions
@djrtwo djrtwo merged commit d0d2fa1 into dev Feb 22, 2019
@djrtwo djrtwo deleted the v-guide-bugs branch February 22, 2019 15:34
hwwhww added a commit to ethereum/trinity that referenced this pull request Feb 24, 2019
* Update privkeys fixtures, thanks to VB

* Address ethereum/consensus-specs#672: fix up previous epoch logic around genesis

* Address ethereum/consensus-specs#627: fix off by one attestaton issue

* Fix attester tools

1. Fix `create_mock_signed_attestation`: Address ethereum/consensus-specs#671
2. Fix `test_demo.py`
	1. Use queued `attestations_map: Dict[Slot, Sequence[Attestation]]` to keep the generated attestations, and include them when reache `MIN_ATTESTATION_INCLUSION_DELAY`.
	2. Add justification assertions

* PR feedback

* PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants