Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update is_power_of_two to not use log2 #674

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Update is_power_of_two to not use log2 #674

merged 2 commits into from
Feb 22, 2019

Conversation

decanus
Copy link
Contributor

@decanus decanus commented Feb 22, 2019

No description provided.

hwwhww
hwwhww approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! It's also faster: ethereum/trinity#280

@djrtwo
Copy link
Contributor

djrtwo commented Feb 22, 2019

Works for me. Definitely better and simpler.
I'll note: this is distinctly and implementation detail -- use whatever implementation you want!

@djrtwo djrtwo merged commit 59be8d8 into ethereum:dev Feb 22, 2019
@prestonvanloon prestonvanloon mentioned this pull request Feb 22, 2019
Merged
@terencechain terencechain mentioned this pull request Feb 25, 2019
Closed
@terencechain terencechain mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@decanus @djrtwo @hwwhww