fix zero being power of two #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
commented
Feb 22, 2019
| @@ -27,7 +27,7 @@ func CeilDiv8(n int) int { | |||
| // IsPowerOf2 returns true if n is an | |||
| // exact power of two. False otherwise. | |||
| func IsPowerOf2(n uint64) bool { | |||
| return (n & (n - 1)) == 0 | |||
| return n != 0 && (n&(n-1)) == 0 | |||
There was a problem hiding this comment.
formatting was from gofmt so i guess this is the preferred spacing
terencechain
approved these changes
Feb 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
==========================================
+ Coverage 70.79% 70.85% +0.05%
==========================================
Files 97 97
Lines 6879 6879
==========================================
+ Hits 4870 4874 +4
+ Misses 1564 1561 -3
+ Partials 445 444 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zero isn't a power of two
Verified inline with spec PR: ethereum/consensus-specs#674