Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milder ejections #784

Merged
merged 3 commits into from
Mar 19, 2019
Merged

Milder ejections #784

merged 3 commits into from
Mar 19, 2019

Conversation

JustinDrake
Copy link
Collaborator

@JustinDrake JustinDrake commented Mar 15, 2019 •
edited
Loading

See item 22 in #675.

Two reasons for this PR:

  1. Send ejections to the exit churn mechanism (partially addressing Include ejections and penalties when calculating validator churn #527).
  2. Avoid sudden drops in the active validator count. (Somewhat related to 1.)

@JustinDrake
Milder ejections
4a8d748 
See item 22 in #675. Also partially addresses #527.
JustinDrake added a commit that referenced this pull request Mar 15, 2019
@JustinDrake
Include recently slashed churn in churn queue
e912ed7 
Addresses #527 in combination with #784.
@JustinDrake JustinDrake mentioned this pull request Mar 15, 2019
Merged
@djrtwo
Copy link
Contributor

djrtwo commented Mar 19, 2019 •
edited
Loading

@JustinDrake Can you add a line or two in the PR comment on why this is desirable? Is it mainly to send through regular churn mechanism to prevent too greatly affecting the safety margins?

@JustinDrake
Copy link
Collaborator Author

Two reasons:

  1. Send ejections to the exit churn mechanism.
  2. Avoid sudden drops in the active validator count. (Somewhat related to 1.)

@djrtwo djrtwo merged commit fe3eef2 into dev Mar 19, 2019
@djrtwo djrtwo deleted the JustinDrake-patch-12 branch March 19, 2019 18:31
sorpaas added a commit to paritytech/shasper that referenced this pull request May 2, 2019
@sorpaas
update v0.6: milder ejections (ethereum/consensus-specs#784)
0e0a868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbuterin vbuterin vbuterin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JustinDrake @djrtwo @vbuterin