Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include recently slashed churn in exit churn queue #785

Merged
merged 7 commits into from
Mar 19, 2019
Merged

Conversation

JustinDrake
Copy link
Collaborator

@JustinDrake JustinDrake commented Mar 15, 2019

Addresses #527 in combination with #784.

These changes were made to keep a tighter bound on validator churn to ensure adequate safety margins when changing v-sets

  • add the recently slashed balances to the exit churn to prevent too much turn over in the case of slashed exits
  • do not process exits at all if too long since last validator registry change to avoid counting errors wrt slashed balance array

Copy link
Contributor

@vbuterin vbuterin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JustinDrake JustinDrake mentioned this pull request Mar 18, 2019
balance_churn += get_effective_balance(state, index)
if balance_churn > max_balance_churn:
break
if state.current_epoch < state.validator_registry_update_epoch + LATEST_SLASHED_EXIT_LENGTH:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you blocking exits if there have been LATEST_SLASHED_EXIT_LENGTH epochs since last registry update?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussing here. It's a simplification to avoid caching a slashed_balance.

@djrtwo djrtwo merged commit 571439b into dev Mar 19, 2019
@djrtwo djrtwo deleted the JustinDrake-patch-13 branch March 19, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants