Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Port Solidity deposit contract #1987

Closed
wants to merge 43 commits into from
Closed

WIP: Port Solidity deposit contract #1987

wants to merge 43 commits into from

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jul 23, 2020

Address #1968

TODOs

  • Port the whole repo with commit history
  • Integrate the dapp.tools tests with CI
  • Relicense Apache-2.0 to ???
  • Clean up the configuration and add the web3.py tester back to the CI
  • Clean up the documents

axic and others added 30 commits April 15, 2020 00:32
@axic
Genesis
f441301
@axic
First implementation of the deposit() function only
65ce39b
@axic
Implement get_deposit_count() and get_deposit_root()
b0c9d8c
@axic
Add Makefile and instructions for the tests in the README
faecab1
@axic
Add .gitattributes with Solidity
304bdc9
@axic
Fix a typo in the assertion (within the comments)
2000988
@axic
Add license header and clarify comment
3aaf6f0
@axic
Consider get_deposit_count and get_deposit_root part of the external …
9957540 
…interface
@axic
Drop masking because of explicit uint8 conversion (#5)
c8aa12f
@chriseth
Make use of constants. (#7)
c8fdabb
@axic @MrChico
Inline bytesN(0) instead of custom zero_bytesN vars (#8)
f2b38a8 
Co-authored-by: Martin Lundfall <martin.lundfall@protonmail.com>
@axic
Require deposit amount to fit into uint64 (#9)
35cf7d2 
Ref #1726
@MrChico
Defensive handling of dead path (#13)
e3ed629
@MrChico
Remove unused variable (#15)
a49abab
@axic @MrChico
Clarify/remove some comments (#16)
72ad3a7 
* Remove assert(deposit_count <= 2**64-1) comment
* Remove the outdated TODO comment
* Rephrase some comments

Co-authored-by: MrChico <martin.lundfall@protonmail.com>
@MrChico
Require deposit to be divisible by GWEI (#14)
d12d660
@axic
Move ABI checks to be first in the code (#10)
dbfccc6
@axic
Add CircleCI configuration (#18)
beca1e5 
* Simplify Makefile
* Add CircleCI configuration
@MrChico @axic
Add revert reason strings (#11)
dbea82f 
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
@axic
Use "literal metadata sources" setting (#21)
032c6b8
@axic
Add ERC-165 support (#4)
dea283f
@axic
Add test job for running eth2.0-specs tests (#25)
619e1af 
Also use python:3.8.1 docker image.
@MrChico
Add unit test and fuzzing against Vyper (#20)
fea839f
@axic
Split CircleCI jobs (#26)
92dcded
@axic
Lock in Solidity 0.6.8 on CircleCI (#27)
a70a0bd 
* Fix Makefile on macOS
* Lock circleci to solc:0.6.8-alpine
* Lock version to 0.6.8
@axic
Enable optimizer and set to 5m runs (#28)
28bb284 
The `deposit` function can be used up to 2^32-1 times anyway.
@axic
Use 0.6.8 features (#22)
edd4b4e
@axic
Move require(deposit_count) statement to where the value is used (pos…
8ed6164 
…t hash calculation) (#23)

This tightly couples all require statements to their places of use.
@axic
Compare against eth2.0-specs v0.11.2 (#30)
b30a990
@MrChico
Use less constants and fold the expressions into require statements (#24
ef58157 
)
@djrtwo
Copy link
Contributor

djrtwo commented Aug 10, 2020

@hwwhww are there any blockers here? We should try to get this out in a release asap

@hwwhww
Copy link
Contributor Author

hwwhww commented Aug 11, 2020

@djrtwo
waiting for merging axic/eth2-deposit-contract#38 🙏

@axic
Copy link
Member

axic commented Aug 13, 2020

Apologies for the delays, merged everything "upstream". And tagged it r2: axic/eth2-deposit-contract#38 (comment)

@axic axic mentioned this pull request Aug 13, 2020
Merged
@hwwhww hwwhww mentioned this pull request Aug 17, 2020
Merged
4 tasks
@hwwhww
Copy link
Contributor Author

hwwhww commented Aug 17, 2020

replaced by #2019

@hwwhww hwwhww closed this Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO NOT MERGE scope:deposit contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hwwhww @djrtwo @axic @chriseth @MrChico