Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown links that reference / in design principles throw a Github 404 #1103

Closed
ryancreatescopy opened this issue Jun 9, 2020 · 3 comments · Fixed by #1248
Closed

Markdown links that reference / in design principles throw a Github 404 #1103

ryancreatescopy opened this issue Jun 9, 2020 · 3 comments · Fixed by #1248
Labels
bug 🐛 Something isn't working

Comments

@ryancreatescopy
Copy link
Contributor

Describe the bug
When trying to navigate via the links that refer to the root structure of ethereum.org rather than a full hyperlink in the design principles file, I'm sent to GitHub 404s instead of intended pages.

For example:
[Ethereum.org](http://ethereum.org) works
[across our site](/) doesn't work

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/ethereum/ethereum-org-website/blob/dev/design-principles.md
  2. Scroll to the bottom
  3. Follow "Across our site" or "style guide"
  4. See 404 page

Note: this affects most links on the page but this is the clearest way of demoing the bug.

Expected behavior
The links should take you to pages on the ethereum.org site and not github 404s

Screenshots
image
image

Desktop (please complete the following information):

  • iOS
  • Chrome version 83.0.4103.61
  • Brave version 1.8.96 Chromium: 81.0.4044.138
@ryancreatescopy ryancreatescopy added the bug 🐛 Something isn't working label Jun 9, 2020
@ryancreatescopy
Copy link
Contributor Author

We could replace them with hyperlinks: https://ethereum.org for example but this might not be the best option if we can work out a way to reference specific files in the structure like / or /style-guide

@samajammin
Copy link
Contributor

Nice catch. I think I know why this is broken - when I originally added the About page, I added the Purpose & Design Principles docs as web pages as well (at ethereum.org/about/purpose/ & ethereum.org/about/principles, respectively).

Here's the PR: #918

We decided to take them down since they weren't fully fleshed out / intended as pages on our website but I'd like to re-add them. What do you think @ryancreatescopy @jjmstark? Perhaps this could be an initiative next sprint: revamping the project README, the purpose & design principles pages.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 17, 2020
@samajammin samajammin removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 17, 2020
samajammin added a commit that referenced this issue Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants