Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing reorg [Fixes #1103 + #1247] #1248

Merged
merged 21 commits into from
Jul 24, 2020
Merged

Contributing reorg [Fixes #1103 + #1247] #1248

merged 21 commits into from
Jul 24, 2020

Conversation

ryancreatescopy
Copy link
Contributor

@ryancreatescopy ryancreatescopy commented Jul 22, 2020

Description

We had too many principles (that were a little out of date) spread out across our repo and website. Have updated and incorporated them into more relevant sections of the site.

  • Updated About page to include content from core principles and purpose
  • Updated the README to focus on explaining to users how to fork, create PRs and set up local environments
  • Created contributing section with relevant pages for different contribution types (and supporting info e.g. wallets and dapps policy) – I believe this is a more robust strategy as we potentially expand contribution types in the future. It also gives us space to create a more appealing landing page for contributing in the future and even work on additional ideas such as swag and acknowledgements features.
  • Removed .md files that weren't in our site content that are no longer relevant.

This PR also includes a few tweaks to the Roadmap component (which I adjusted to improve the About page)

Related Issue

Fixes #1103 and fixes #1247

@samajammin samajammin added feature ✨ This is enhancing something existing or creating something new content 🖋️ This involves copy additions or edits labels Jul 22, 2020
Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great! Big fan of the structure. Excited to get this out there.

Made a bunch of comments w/ suggested tweaks. Happy to pair on this.

src/components/Footer.js Show resolved Hide resolved
src/content/about/index.md Outdated Show resolved Hide resolved
src/content/about/index.md Outdated Show resolved Hide resolved
src/content/about/index.md Outdated Show resolved Hide resolved
src/content/about/index.md Outdated Show resolved Hide resolved
src/content/contributing/index.md Outdated Show resolved Hide resolved
src/content/contributing/index.md Outdated Show resolved Hide resolved
src/content/contributing/adding-articles/index.md Outdated Show resolved Hide resolved
src/styles/layout.css Show resolved Hide resolved
Ryan Cordell and others added 18 commits July 24, 2020 09:48
need to fix contributors table
uppercasing Foundation in Ethereum Foundation

Co-authored-by: Sam Richards <sbrichards@gmail.com>
Correcting onboarding typo

Co-authored-by: Sam Richards <sbrichards@gmail.com>
Adding link to about page

Co-authored-by: Sam Richards <sbrichards@gmail.com>
Rewording articles criteria

Co-authored-by: Sam Richards <sbrichards@gmail.com>
Removing ethereum.org from internal link

Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Co-authored-by: Sam Richards <sbrichards@gmail.com>
Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@samajammin samajammin merged commit 803f873 into dev Jul 24, 2020
@samajammin samajammin deleted the contributing branch July 24, 2020 17:42
@samajammin samajammin mentioned this pull request Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits feature ✨ This is enhancing something existing or creating something new
Projects
None yet
2 participants