Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HubHero allows for empty H1 #12253

Closed
1 of 2 tasks
minimalsm opened this issue Feb 21, 2024 · 0 comments · Fixed by #12254
Closed
1 of 2 tasks

HubHero allows for empty H1 #12253

minimalsm opened this issue Feb 21, 2024 · 0 comments · Fixed by #12254
Assignees
@minimalsm
Labels
bug 🐛 Something isn't working SEO

Comments

@minimalsm
Copy link
Contributor

minimalsm commented Feb 21, 2024 •
edited
Loading

Describe the bug

The HubHero component allows an optional 'title' prop, which is used to render the H1. If the 'title' is not passed, an empty H1 is rendered.

To reproduce

  1. Go to 'https://ethereum.org/roadmap'
  2. Inspect source for hub hero
  3. See error

Expected behavior

An H1 should always be present and not empty

Screenshots

Screenshot 2024-02-21 at 13 42 40

Related issues

#12252

Would you like to work on this issue?

  • Yes
  • No
@minimalsm minimalsm added bug 🐛 Something isn't working SEO labels Feb 21, 2024
@minimalsm minimalsm self-assigned this Feb 21, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Feb 21, 2024
@minimalsm minimalsm removed the needs triage 📥 This issue needs triaged before being worked on label Feb 21, 2024
@minimalsm minimalsm mentioned this issue Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minimalsm minimalsm

Labels
bug 🐛 Something isn't working SEO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use header as H1 if title is missing in HubHero ethereum/ethereum-org-website
1 participant
@minimalsm