Flags SyncMode cannot be combined with LightServ in geth v1.8.2

[rkeene]

See comment here: #15514 (comment)

System information

Geth version: v1.8.2
OS & Version: All

Expected behaviour

geth --syncmode=full --lightserv=80 should work

Actual behaviour

geth --syncmode=full --lightserv=80 produces an error indicating that --syncmode and --lightserv cannot be combined

Steps to reproduce the behaviour

Run: geth --syncmode=full --lightserv=80

There appears to be an issue with the checkExclusive function with respect to string arguments -- they're not really used in the way the comment described above that function suggests they might, this leads to a bug combining --syncmode=full and --lightserv, when it is intended to prevent --syncmode=light and --lightserv from being combined.

[jmooo]

I just ran into this updating our systemd script which specifically defined --syncmode "fast". Since that is the geth default I was able to just remove the line from all our systemd units to get around it, but not ideal

[RaghavSood]

--syncmode=full and --lightserv also produce the same error in 1.8.10

[ulope]

This is unfortunate since it prevents a --lightserv node from running with --syncmode full which IMO would be desirable.

[holiman]

Works for me

[user@work go-ethereum]$ build/bin/geth --datadir /tmp/blabla  --syncmode=full --lightserv=80 
INFO [09-24|10:23:09.143] Bumping default cache on mainnet         provided=1024 updated=4096
WARN [09-24|10:23:09.143] Sanitizing cache to Go's GC limits       provided=4096 updated=2590
INFO [09-24|10:23:09.145] Maximum peer count                       ETH=50 LES=100 total=150
INFO [09-24|10:23:09.145] Smartcard socket not found, disabling    err="stat /run/pcscd/pcscd.comm: no such file or directory"
ERROR[09-24|10:23:09.145] Failed to enumerate USB devices          hub=ledger vendor=11415 failcount=1 err="failed to initialize libusb: libusb: unknown error [code -99]"
ERROR[09-24|10:23:09.146] Failed to enumerate USB devices          hub=trezor vendor=21324 failcount=1 err="failed to initialize libusb: libusb: unknown error [code -99]"
ERROR[09-24|10:23:09.146] Failed to enumerate USB devices          hub=trezor vendor=4617  failcount=1 err="failed to initialize libusb: libusb: unknown error [code -99]"
ERROR[09-24|10:23:09.146] Failed to enumerate USB devices          hub=ledger vendor=11415 failcount=2 err="failed to initialize libusb: libusb: unknown error [code -99]"
ERROR[09-24|10:23:09.146] Failed to enumerate USB devices          hub=trezor vendor=21324 failcount=2 err="failed to initialize libusb: libusb: unknown error [code -99]"
ERROR[09-24|10:23:09.146] Failed to enumerate USB devices          hub=trezor vendor=4617  failcount=2 err="failed to initialize libusb: libusb: unknown error [code -99]"
INFO [09-24|10:23:09.146] Starting peer-to-peer node               instance=Geth/v1.9.5-unstable-4ec5496c-20190923/linux-amd64/go1.11.2
INFO [09-24|10:23:09.147] Allocated trie memory caches             clean=647.00MiB dirty=647.00MiB
INFO [09-24|10:23:09.147] Allocated cache and file handles         database=/tmp/blabla/geth/chaindata cache=1.26GiB handles=2048
INFO [09-24|10:23:09.153] Opened ancient database                  database=/tmp/blabla/geth/chaindata/ancient
INFO [09-24|10:23:09.153] Writing default main-net genesis block 
INFO [09-24|10:23:09.402] Persisted trie from memory database      nodes=12356 size=1.79MiB time=51.490333ms gcnodes=0 gcsize=0.00B gctime=0s livenodes=1 livesize=0.00B
INFO [09-24|10:23:09.403] Initialised chain configuration          config="{ChainID: 1 Homestead: 1150000 DAO: 1920000 DAOSupport: true EIP150: 2463000 EIP155: 2675000 EIP158: 2675000 Byzantium: 4370000 Constantinople: 7280000 Petersburg: 7280000 Istanbul: <nil> Engine: ethash}"
INFO [09-24|10:23:09.403] Disk storage enabled for ethash caches   dir=/tmp/blabla/geth/ethash count=3
INFO [09-24|10:23:09.403] Disk storage enabled for ethash DAGs     dir=/home/user/.ethash      count=2
INFO [09-24|10:23:09.403] Initialising Ethereum protocol           versions=[63] network=1 dbversion=<nil>
WARN [09-24|10:23:09.403] Upgrade blockchain database version      from=<nil> to=7
INFO [09-24|10:23:09.426] Loaded most recent local header          number=0 hash=d4e567…cb8fa3 td=17179869184 age=50y5mo1w
INFO [09-24|10:23:09.427] Loaded most recent local full block      number=0 hash=d4e567…cb8fa3 td=17179869184 age=50y5mo1w
INFO [09-24|10:23:09.427] Loaded most recent local fast block      number=0 hash=d4e567…cb8fa3 td=17179869184 age=50y5mo1w
INFO [09-24|10:23:09.427] Regenerated local transaction journal    transactions=0 accounts=0

[karalabe]

Fixed a while back by #17803.