-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banner on the console #18243
Comments
Can you please provide some more details on what this banner should contain and look like? Thanks! |
Let's collect some ideas here...
|
It could also list any important config options that arent already displayed or are defaulted in, the warning for insecure configurations could include details, additionally it could include the licensing information which is the GNU Lesser General Public License v3.0 I believe. Also what should be included for insecure configuration? And should tickets be linked to the github page then? Node info and an accounts list may be nice? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I would personally find this feature very useful, and I would be more than happy to implement it if someone wants to assign me! |
@nathanio that's good news. Please be aware it's not thoroughly specified, so part of the job is to figure it out :) |
Hey, just a quick question. One issue I've noticed is that the console gets filled up so quickly when dev mode is run that it can be difficult to read the banner. Should I make it so that the user has to press a key when they run |
I'm asking around in the team |
please don't. This can break current setups and if things are headless might cause some WTFs, broken workflows and wasted time. Maybe a sleep after the banner - but then we need another flag to disable this. |
Yes, this was my exact concern. And you are completely right about having the option to disable the sleep/prompt. A better option might be having the banners disabled by default, and then the users that need them could manually enable them. |
Hi, What is the status of this Issue? someone is already working in this? |
@solrac97gr It's open for taking if someone wants to work on it. I've had it on my backlog for a year and kind of forgot about it |
forking and starting to work in this) if you have some suggestion for start? |
@solrac97gr I'd start with collecting the information that might be useful before coding up anything |
Print a banner on the console with general information. If
--dev
was specified, add "welcome to power user mode".The text was updated successfully, but these errors were encountered: