Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

fix: out of sync nano #458

Merged
merged 2 commits into from Sep 5, 2019
Merged

fix: out of sync nano #458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc684e8
fix: out of sync nano
wolovim Sep 5, 2019
e0ff585
chore: share error message in catch
ryanio Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions ethereum_clients/ControlledProcess.js
View file
Open in desktop
Expand Up @@ -161,8 +161,6 @@ class ControlledProcess extends EventEmitter {
}
stop() {
return new Promise((resolve, reject) => {
this.removeStateListeners()

// FIXME kill IPC ? or is it indirectly closed: onIpcEnd
if (!this.proc || !this.isRunning) {
resolve(this)
Expand Down
7 changes: 5 additions & 2 deletions ethereum_clients/Plugin.js
View file
Open in desktop
Expand Up @@ -265,6 +265,7 @@ class Plugin extends EventEmitter {
console.log(
`Plugin ${this.name} (${packagePath}) about to start. Binary: ${binaryPath}`
)

try {
this.process = new ControlledProcess(
binaryPath,
Expand All @@ -273,9 +274,11 @@ class Plugin extends EventEmitter {
)
this.registerEventListeners(this.process, this)
await this.process.start(flags)
} catch (error) {
console.log('error start', error)
} catch (e) {
console.log('Error: could not start plugin')
throw new Error('Plugin Start Error')
}

return this.process
}
async stop() {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -396,10 +396,10 @@
universal-user-agent "^2.0.0"
url-template "^2.0.8"

"@philipplgh/electron-app-manager@^0.50.0":
version "0.50.0"
resolved "https://registry.yarnpkg.com/@philipplgh/electron-app-manager/-/electron-app-manager-0.50.0.tgz#8a69083a55ccf7ad1cf241a1630253380bcbc003"
integrity sha512-ZVYez5UKGeAj2roeif0EZI8KphrvGRrDR/sgxWYphfqKZnXA7igmcKk9qYhKhD6HwC5SMjM1fOwnV18Hm7I8nQ==
"@philipplgh/electron-app-manager@^0.51.0":
version "0.51.0"
resolved "https://registry.yarnpkg.com/@philipplgh/electron-app-manager/-/electron-app-manager-0.51.0.tgz#a93494eaa04cf99dc534591d580398230d81e0cc"
integrity sha512-aFYg9i+GJ/o9sM18w/kqYeqGR1dojdcymwYRhXNgoBdua1phj23ZM1h9+VHZPX3WtOvIN9XHmvET9h3p7mqhRQ==
dependencies:
"@octokit/rest" "^16.27.0"
electron-updater "4.1.2"
Expand Down