Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #51 #53, Add BLS APIs #52

Merged
merged 13 commits into from
Mar 14, 2019
Merged

Fix #51 #53, Add BLS APIs #52

merged 13 commits into from
Mar 14, 2019

Conversation

ChihChengLiang
Copy link
Contributor

@ChihChengLiang ChihChengLiang commented Feb 27, 2019 •
edited
Loading

What was wrong?

#51 #53

How was it fixed?

For the reviewer

  • The code is mostly copied from code, test
  • The implementation should follow the spec

Cute Animal Picture

African penguins Boulder Bay 1

ChihChengLiang
ChihChengLiang commented Feb 27, 2019
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@ChihChengLiang ChihChengLiang mentioned this pull request Mar 3, 2019
Closed
@ChihChengLiang ChihChengLiang changed the title [WIP] Fix #51, Add BLS APIs [WIP] Fix #51 #53, Add BLS APIs Mar 3, 2019
@hwwhww hwwhww mentioned this pull request Mar 4, 2019
Closed
ChihChengLiang
ChihChengLiang commented Mar 6, 2019
View reviewed changes
py_ecc/bls_api/utils.py Outdated Show resolved Hide resolved
py_ecc/bls_api/utils.py Outdated Show resolved Hide resolved
py_ecc/bls_api/typing.py Outdated Show resolved Hide resolved
py_ecc/bls_api/utils.py Outdated Show resolved Hide resolved
@ChihChengLiang ChihChengLiang changed the title [WIP] Fix #51 #53, Add BLS APIs Fix #51 #53, Add BLS APIs Mar 6, 2019
vbuterin
vbuterin reviewed Mar 6, 2019
View reviewed changes
py_ecc/bls_api/utils.py Outdated Show resolved Hide resolved
Bhargavasomu
Bhargavasomu reviewed Mar 6, 2019
View reviewed changes
py_ecc/bls/typing.py Outdated Show resolved Hide resolved
py_ecc/bls/typing.py Outdated Show resolved Hide resolved
@ChihChengLiang ChihChengLiang mentioned this pull request Mar 7, 2019
Closed
@ChihChengLiang
Add BLS APIs
55d4b10
@ChihChengLiang
add constants and typing
b31df48
@ChihChengLiang
Redefine G1_to_pubkey, pubkey_to_G1, G2_to_signature, and signature_t…
77b6fca 
…o_G2. Fix modular_squareroot typing
@ChihChengLiang
Fix modular_squareroot according to spec
577e2d8
@ChihChengLiang
update a,b,c_flag as spec says
4da0537 
disable strict check for now

fix a_flag
@ChihChengLiang
upgrade typing
6aed0e3 
move constants

import from py_ecc.fields and sort import

the cast is not necessary

disable type check

Polish comments and docstrings

fix test

fix comment

removed unused comment
@ChihChengLiang
rename module: bls_api -> bls
1fe7e05
@ChihChengLiang
rename modular_squareroot -> modular_squareroot_in_FQ2
13fa1c7
@ChihChengLiang
check a_flag1 for y_re if y_im happens to be 0
445743a
@ChihChengLiang
test flags in compression and decompression
74fbceb
@ChihChengLiang
Fix the real & imaginary parts compression and decompression in G2
cfc760b 
add TODO comment for test_G2_compress_and_decompress_flags
@ChihChengLiang
add document of BLS api
a127534
@hwwhww hwwhww merged commit b9750d9 into ethereum:master Mar 14, 2019
@ChihChengLiang ChihChengLiang deleted the add-bls branch March 14, 2019 09:06
@renovate renovate bot mentioned this pull request Mar 14, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbuterin vbuterin vbuterin left review comments

@Bhargavasomu Bhargavasomu Bhargavasomu left review comments

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix BLS Signature byte representation of G1 and G2 points
4 participants
@ChihChengLiang @vbuterin @hwwhww @Bhargavasomu