Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

refactor peers.py & packeter.py #80

Closed
heikoheiko opened this issue May 6, 2014 · 1 comment
Closed

refactor peers.py & packeter.py #80

heikoheiko opened this issue May 6, 2014 · 1 comment

Comments

@heikoheiko
Copy link
Member

  • currently serialization is done in packeter.py; interpretation and casting of deserialized data is (partially) done in peers.py; networking code is spread over two files which makes development complicated and error prone
    • serialization code should exist next to the deserialization code in peer.py
  • wire protocol documentation in docstrings went missing after refactoring
    • re-add wire protocol documentation
  • blocks and transactions are exchanged as rlp.decode(obj.serialized())
    • de/serialization should accept and return Transaction and Block instances
@heikoheiko
Copy link
Member Author

introduced blocks.TransientBlocks as a start

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants