Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce strict mode in the inline assembly #1824

Closed
pirapira opened this issue Mar 25, 2017 · 1 comment
Closed

Enforce strict mode in the inline assembly #1824

pirapira opened this issue Mar 25, 2017 · 1 comment
Assignees
@chriseth
Labels
breaking change ⚠️

Comments

@pirapira
Copy link
Member

pirapira commented Mar 25, 2017 •
edited
Loading

Currently, Solidity exposes inline assembly without checks proposed in #1820 #1821 #1822 #1823 #1825 . This is not safe.

  • strict mode (Assembly: Strict mode #1820) should be enforced on the inline assembly
  • consider making the next breaking release 0.5.0 earlier for this change
@pirapira pirapira changed the title Remove inline assembly until sufficient checks are implemented Enforce strict mode in the inline assembly Mar 29, 2017
@axic
Copy link
Member

axic commented Jan 6, 2018

After #3317 is applied the --strict-assembly commandline option will need to be removed too.

@chriseth chriseth self-assigned this Feb 15, 2018
@chriseth chriseth mentioned this issue Feb 15, 2018
Merged
@axic axic closed this as completed in #3527 Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chriseth chriseth

Labels
breaking change ⚠️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@axic @pirapira @chriseth