Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section about EVM version and explain its implications #4259

Closed
axic opened this issue Jun 11, 2018 · 6 comments
Closed

Add section about EVM version and explain its implications #4259

axic opened this issue Jun 11, 2018 · 6 comments
Assignees

Comments

@axic
Copy link
Member

axic commented Jun 11, 2018

It should mention:

  • the different versions and what different behaviour is introduced with each,
  • the default version used
  • implications in private chains
@chfast
Copy link
Member

chfast commented Jun 11, 2018

I'm not sure you like it, but we are using "EVM revision" name in EVMC to enumerate hard fork changes.

@axic
Copy link
Member Author

axic commented Jun 11, 2018

I'm not sure how much it matters (need to see the section written up), but the fact is the flag is called currently evmVersion (in JSON) or --evmversion (on CLI) so probably makes sense using this wording to avoid confusion.

@ChrisChinchilla
Copy link
Contributor

@axic

Can I find most of the details needed to meet what's needed in the various referenced issues and PRs?

And Is this also made against develop, or a different branch?

@axic
Copy link
Member Author

axic commented Jul 30, 2018

Can I find most of the details needed to meet what's needed in the various referenced issues and PRs?

The references PRs don't really add too much, they are different issues all caused by not compiling the contract for the right EVM version.

What needs to be added is:

  • the compiler has an option to select the target EVM version
  • must list the target options and state the default is byzantium
  • should add it into the standardjson documentation and the cli documentation

And Is this also made against develop, or a different branch?

All of it should be against develop.

@ChrisChinchilla
Copy link
Contributor

ChrisChinchilla commented Aug 3, 2018

@axic To check, the top comments says:

the different versions and what different behaviour is introduced with each,
implications in private chains

The latest one doesn't. Still want those too?

@axic
Copy link
Member Author

axic commented Aug 3, 2018

Sure, all of this detail is useful. Practically it is one sentence: compiling for the wrong EVM version likely can result in wrong, strange and failing behaviour. Please ensure, especially if running a private chain, that the correct EVM version is used. Note: there might be cases where backwards compatibility exists between different EVM versions, but deducting that is the onus of the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants