[Yul] Use map join algorithm for performance. #5333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failing |
leonardoalt
reviewed
Nov 7, 2018
| @@ -0,0 +1,623 @@ | |||
| { | |||
There was a problem hiding this comment.
Not really sure how to review this file...
There was a problem hiding this comment.
The point of fullSuite is not necessarily correctness (that is tested in the individual steps) but rather checking that the result does not miss any optimizations.
chriseth
force-pushed
the
joinPerformance
branch
from
e6c09f0
to
c7558cd
Compare
|
Updated. |
chriseth
force-pushed
the
joinPerformance
branch
from
c7558cd
to
d9aef90
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5333 +/- ##
===========================================
+ Coverage 88.1% 88.12% +0.01%
===========================================
Files 323 323
Lines 32615 32630 +15
Branches 3869 3869
===========================================
+ Hits 28737 28756 +19
+ Misses 2581 2580 -1
+ Partials 1297 1294 -3
|
|
Updated. |
chriseth
force-pushed
the
joinPerformance
branch
from
d9aef90
to
3f6eba4
Compare
leonardoalt
reviewed
Nov 12, 2018
| { | ||
| for (auto& var: _other.m_assignments) | ||
| if (m_assignments.count(var.first)) | ||
| // TODO Perhaps it is better to just created a sorted list |
There was a problem hiding this comment.
Small typo here created -> create
leonardoalt
previously approved these changes
Nov 12, 2018
chriseth
force-pushed
the
joinPerformance
branch
from
3f6eba4
to
b145443
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.