-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Yul] Use map join algorithm for performance. #5333
Conversation
Test failing |
@@ -0,0 +1,623 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure how to review this file...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of fullSuite
is not necessarily correctness (that is tested in the individual steps) but rather checking that the result does not miss any optimizations.
e6c09f0
to
c7558cd
Compare
Updated. |
c7558cd
to
d9aef90
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5333 +/- ##
===========================================
+ Coverage 88.1% 88.12% +0.01%
===========================================
Files 323 323
Lines 32615 32630 +15
Branches 3869 3869
===========================================
+ Hits 28737 28756 +19
+ Misses 2581 2580 -1
+ Partials 1297 1294 -3
|
Updated. |
d9aef90
to
3f6eba4
Compare
{ | ||
for (auto& var: _other.m_assignments) | ||
if (m_assignments.count(var.first)) | ||
// TODO Perhaps it is better to just created a sorted list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo here created
-> create
3f6eba4
to
b145443
Compare
No description provided.