Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to Shanghai (partially) #1160

Closed
wants to merge 1 commit into from

Conversation

rodiazet
Copy link
Contributor

@rodiazet rodiazet commented Feb 9, 2023

Most of the test are updated to Shanghai. Still a couple of errors listed in attached doc.
Testing on evmone master branch

https://hackmd.io/@etgDMnCFQgS7tnZ9yjkOPw/SylTKkypj

@winsvega
Copy link
Collaborator

this is a matter of revisioning each test that failed like this. because need to be sure that the test didn't fail and still works and affected by shanghai in a good way. (gas change, eip interaction)

for this reason there are warning when expect section uses coinbase balance or origin balance checks.

@rodiazet
Copy link
Contributor Author

rodiazet commented Feb 10, 2023

this is a matter of revisioning each test that failed like this. because need to be sure that the test didn't fail and still works and affected by shanghai in a good way. (gas change, eip interaction)

for this reason there are warning when expect section uses coinbase balance or origin balance checks.

Sure. Just wanted to know which tests I didn't update do Shanghai because it probably takes minutes to someone who is more familiar with the generated tests. I hope it's beneficial in any way.

@winsvega
Copy link
Collaborator

is latest geth master shanghai ready?

@winsvega
Copy link
Collaborator

in progress. updating all tests to Shanghai. I've checked all of them seems to be no breaking changes. Ori must fix his vectors now.

@winsvega winsvega closed this Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants