Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move creation tests to validation tests #1337

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

hugo-dc
Copy link
Member

@hugo-dc hugo-dc commented Feb 7, 2024

Previous tests validating EOF by creating using CREATE/CREATE2/CreateTransaction were moved to the EOF Validation test format, as it is no longer valid EOF creation using the previous legacy methods.

@winsvega
Copy link
Collaborator

winsvega commented Feb 8, 2024

Test Case "stEIP3540": (8 of 13)
Error: Compiled test folder contains tests without Filler: 
 /home/travis/build/ethereum/tests/EIPTests/BlockchainTests/StateTests/stEOF/stEIP3540/CREATE2_EOF1Invalid_FromEOF.json
 /home/travis/build/ethereum/tests/EIPTests/BlockchainTests/StateTests/stEOF/stEIP3540/CreateTransactionInvalidEOF1.json

The generated tests need to be moved too

@hugo-dc
Copy link
Member Author

hugo-dc commented Feb 16, 2024

Removed Blockchain tests without fillers.

@gumb0
Copy link
Member

gumb0 commented Feb 26, 2024

@hugo-dc Please rebase.

@hugo-dc hugo-dc marked this pull request as ready for review February 26, 2024 22:17
@hugo-dc
Copy link
Member Author

hugo-dc commented Feb 26, 2024

Rebased

@gumb0
Copy link
Member

gumb0 commented Feb 27, 2024

stEOF/ori/CreateEOF1Filler.yml source removed, blockchain test removed, but CreateEOF1.json is not removed.
(Why no CI warning about this?)

@gumb0
Copy link
Member

gumb0 commented Feb 27, 2024

Same about stEIP3670/CREATE2_EOF1Invalid_FromEOF and stEIP3670/CREATE_EOF1Invalid_FromEOF

@gumb0
Copy link
Member

gumb0 commented Feb 27, 2024

I just deleted those leftover files, @hugo-dc please check

@hugo-dc
Copy link
Member Author

hugo-dc commented Feb 28, 2024

I just deleted those leftover files, @hugo-dc please check

It looks good now.

(Why no CI warning about this?)

Usually retesteth itself catches json files without fillers when running the tests (not filling), I was double checking by doing that but somehow it didn't reported these files.

Another difference I see is that the BlockchainTest EIPTests/BlockchainTests/StateTests/stEOF/stEIP4200/EOF1_RJUMP_RJUMPI_RJUMPV_Execution.json is being modified even though the original yaml file was not changed. The change seems to be in the excessBlobGas, from 0x060000 to 0x00.

@gumb0
Copy link
Member

gumb0 commented Feb 28, 2024

@winsvega This is ready to go from our side, please review.

@winsvega
Copy link
Collaborator

it should be 0x060000 in genesis now. it is a minor correction for the state tests to have 0 in the first block in its blockchain tests form the genesis value must be 60000

@winsvega winsvega merged commit 9cd1ad2 into ethereum:develop Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants