This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Move functions from helpers.py
to committee_helpers.py
and epoch_processing_helpers.py
#262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Too many functions in
helpers.py
, and thetest_helpers.py
is getting longer and longer.How was it fixed?
No logic changes in this PR.
committee_helpers.py
.epoch_processing_helpers.py
.Note the dependencies are:
committee_helpers.py
depends onhelper.py
.epoch_processing_helpers
depends onhelper.py
andcommittee_helpers.py
./cc @pipermerriam @djrtwo @ChihChengLiang @NIC619 @jannikluhn
Any objection to this reorg? If no, I will continue to reorg
test_helpers.py
too.Other thoughts on the file path reorg:
attestation_helpers.py
for the helper functions that related toAttestation
andSlashableAttestation
, but I'm inclined to leave it after Remove placeholder #250 and other in-progressing PR merged._helpers.py
files intohelpers
folder, and remove the suffix.Cute Animal Picture