-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted the rest of the tests to es6 #1203
Conversation
@dacarley please change mocha reporters to You have one test failing:
|
Removed stray console.error line that should not have been committed. Removed dead/commented console.log lines elsewhere in the code.
I switched to the "dot" reporter for Mocha, and removed a stray "console.error" that shouldn't have been in the code at all. I don't see the test failure you're referring to, either on my machine, or in Travis. What node and npm version are you using when you see the failure? |
I use node 6 I think. Not on my comp to check. |
I will try tomorrow again. Thanks for the great work! |
I just tried a fresh enlistment on Node 6.11.5 / NPM 3.10.10, and all is well. |
There seems to be a left over in mocha, because when i run it standalone the test passes: I removed the node modules folder and re-run all and now it passes :) Thanks. Currently the listing is not running, you removed that from the npm test call? Is it because it wouldn't pass yet? |
I'm not sure what you mean by "the listing is not running"? |
Linting |
No, that was an oversight on my part -- I'll address that in my next PR. |
* Converted the rest of the tests to es6 * Switched back to "dot" reporter for mocha. Removed stray console.error line that should not have been committed. Removed dead/commented console.log lines elsewhere in the code.
No description provided.