Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted the rest of the tests to es6 #1203

Merged
merged 2 commits into from Dec 1, 2017
Merged

Converted the rest of the tests to es6 #1203

merged 2 commits into from Dec 1, 2017

Conversation

dacarley
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 27, 2017

Coverage Status

Coverage increased (+0.08%) to 85.006% when pulling f0efdef on blitzpredict:feature/es6-all-tests into 6a133ab on ethereum:1.0ES6.

@frozeman
Copy link
Contributor

frozeman commented Dec 1, 2017

@dacarley please change mocha reporters to dot, it gives better overview errors show the actual problems anyway.

You have one test failing:

  1) web3-providers-http
       send
         should send basic async request:

      AssertionError: expected 'undefined' to equal 'object'
      + expected - actual

      -undefined
      +object

Removed stray console.error line that should not have been committed.
Removed dead/commented console.log lines elsewhere in the code.
@coveralls
Copy link

coveralls commented Dec 1, 2017

Coverage Status

Coverage increased (+0.07%) to 85.0% when pulling e5b05f4 on blitzpredict:feature/es6-all-tests into 6a133ab on ethereum:1.0ES6.

@dacarley
Copy link
Contributor Author

dacarley commented Dec 1, 2017

I switched to the "dot" reporter for Mocha, and removed a stray "console.error" that shouldn't have been in the code at all.

I don't see the test failure you're referring to, either on my machine, or in Travis.

What node and npm version are you using when you see the failure?

@frozeman
Copy link
Contributor

frozeman commented Dec 1, 2017

I use node 6 I think. Not on my comp to check.

@frozeman
Copy link
Contributor

frozeman commented Dec 1, 2017

I will try tomorrow again. Thanks for the great work!

@dacarley
Copy link
Contributor Author

dacarley commented Dec 1, 2017

I just tried a fresh enlistment on Node 6.11.5 / NPM 3.10.10, and all is well.

@frozeman
Copy link
Contributor

frozeman commented Dec 1, 2017

There seems to be a left over in mocha, because when i run it standalone the test passes: mocha test/httpprovider.js.

I removed the node modules folder and re-run all and now it passes :) Thanks.

Currently the listing is not running, you removed that from the npm test call? Is it because it wouldn't pass yet?

@frozeman frozeman merged commit b882ea2 into web3:1.0ES6 Dec 1, 2017
@dacarley
Copy link
Contributor Author

dacarley commented Dec 1, 2017

I'm not sure what you mean by "the listing is not running"?

@frozeman
Copy link
Contributor

frozeman commented Dec 1, 2017

Linting

@dacarley
Copy link
Contributor Author

dacarley commented Dec 1, 2017

No, that was an oversight on my part -- I'll address that in my next PR.

@dacarley dacarley deleted the feature/es6-all-tests branch December 1, 2017 21:36
frozeman pushed a commit that referenced this pull request Apr 19, 2018
* Converted the rest of the tests to es6

* Switched back to "dot" reporter for mocha.
Removed stray console.error line that should not have been committed.
Removed dead/commented console.log lines elsewhere in the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants