Issue and PR template added #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozeman
reviewed
Jul 31, 2018
PULL_REQUEST_TEMPLATE.md
Outdated
| ## Checklist: | ||
|
|
||
| - [ ] I have selected the correct base branch. | ||
| - [ ] I have fixed the tests and extended if necessary. |
There was a problem hiding this comment.
not sure if we should suggest fixing tests, its note like fix your code to pass tests :)
There was a problem hiding this comment.
and adding tests is a must, if new things are added :)
frozeman
reviewed
Jul 31, 2018
PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| - [ ] I have selected the correct base branch. | ||
| - [ ] I have fixed the tests and extended if necessary. | ||
| - [ ] I have performed a self-review of my own code. |
There was a problem hiding this comment.
I also should test my code on the live network.
And we should add, i ran npm run build and tested the resulting file from the dist folder in a browser.
frozeman
suggested changes
Jul 31, 2018
frozeman
approved these changes
Jul 31, 2018
nachomazzara
pushed a commit
to nachomazzara/web3.js
that referenced
this pull request
Jun 4, 2020
* PR and issue template created * PR changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.