Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web3 module options to include_package-core added #2216

Merged
merged 3 commits into from
Jan 27, 2019
Merged

Web3 module options to include_package-core added #2216

merged 3 commits into from
Jan 27, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Jan 26, 2019

Description

Adding of the Web3 module options documentation.

Type of change

  • Documentation

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

@nivida nivida added the Documentation Relates to project wiki or documentation label Jan 26, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.704% when pulling 259ae55 on documentation/web3-module-options into 2cfa2ea on 1.0.

@coveralls
Copy link

coveralls commented Jan 26, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 92.704% when pulling fcba5a9 on documentation/web3-module-options into d816865 on 1.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.704% when pulling 259ae55 on documentation/web3-module-options into 2cfa2ea on 1.0.

@nivida nivida merged commit 599c52e into 1.0 Jan 27, 2019
@nivida nivida deleted the documentation/web3-module-options branch January 27, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation Relates to project wiki or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nivida @coveralls