Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle size improvements for the web3-eth-ens package #3179

Merged
merged 4 commits into from
Nov 12, 2019
Merged

Bundle size improvements for the web3-eth-ens package #3179

merged 4 commits into from
Nov 12, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Nov 5, 2019 •
edited
Loading

Minified UMD bundle size of web3-eth-ens reduced from 581kb to 213kb.

(has PR #3160 as the base branch)

@nivida nivida added Enhancement Includes improvements or optimizations 1.x 1.0 related issues CI labels Nov 5, 2019
@coveralls
Copy link

coveralls commented Nov 5, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 83.387% when pulling d7e7ede on bundle-improvement-ens into b5e0d2e on issue/3155.

@nivida nivida marked this pull request as ready for review November 6, 2019 10:50
@nivida nivida requested a review from cgewecke November 6, 2019 10:51
@nivida nivida merged commit a07ea24 into issue/3155 Nov 12, 2019
@nivida nivida deleted the bundle-improvement-ens branch November 14, 2019 16:16
@cgewecke cgewecke mentioned this pull request Nov 20, 2019
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke Awaiting requested review from cgewecke

Assignees
No one assigned
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nivida @coveralls